Problem/Motivation

  1. additionalData and cancelable not documented as optional parameters, while they have default values.
  2. originalEvent not documented as optional, and doesn't have default value. However, judging the contents of the function, it's actually also an optional parameter.

Proposed resolution

Document additionalData and cancelable as optional. Add default value for originalEvent and document it as optional.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork a11y_autocomplete-3247142

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

lauriii opened merge request !32

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Active » Needs review

nod_ made their first commit to this issue’s fork.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Needs review » Reviewed & tested by the community

  • nod_ committed 5167c1a on 1.0.x authored by lauriii 
    Issue #3247142 by lauriii: triggerEvent() parameters documented...
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.