Problem/Motivation

The refactor started broke many thing in the jquery ui shim test suite. This is an alternate take to make the minium amount of changes while implementing the various improvements and keep the lib test coverage at the same time.

Reimplement the following issues on top of the pre #3244313: Separate concerns source:

Issue fork a11y_autocomplete-3246362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_ created an issue. See original summary.

nod_ opened merge request !31

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Issue summary: View changes
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Needs work » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Related issues: +#3076171: Provide a new library to replace jQuery UI autocomplete
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Assigned: nod_ » Unassigned
Priority: Normal » Critical
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs review » Reviewed & tested by the community

This looks good! Thank you @nod_! 👏

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

All right core patch is green, this is looking ok. Unless there are concerns I'll merged that tomorrow

  • nod_ committed b9a548d on 1.0.x 
    Issue #3246362 by nod_, lauriii: Keep autocomplete lib passing jquery ui...
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.