Problem/Motivation

Removed the usage of Yaml::decode in includes/webform.install.update.inc for safe handling of empty arrays

Steps to reproduce

Go to includes/webform.install.update.inc file, we can see Yaml::decode usage.

Proposed resolution

Remove Yaml::decode class because empty can't handled by Yaml::decode method.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3243565-4-6.x.patch8.74 KBjrockowitz
#4 3243565-3.patch9.06 KBjrockowitz
#2 3243565-02.patch5.46 KBiyyappan.govind
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

iyyappan.govind created an issue. See original summary.

iyyappan.govind’s picture

iyyappan.govind
he/him
Primary language Tamil
Location Chennai, India
CreditAttribution: iyyappan.govind at BORN Commerce commented
FileSize
3243565-02.patch5.46 KB

Please review my patch, Thanks

iyyappan.govind’s picture

iyyappan.govind
he/him
Primary language Tamil
Location Chennai, India
CreditAttribution: iyyappan.govind at BORN Commerce commented
Status: Active » Needs review
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Version: 6.1.0-beta2 » 8.x-5.x-dev
FileSize
3243565-3.patch9.06 KB

We need to fix this in 8.x-5.x and then 6.x

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
FileSize
3243565-4-6.x.patch8.74 KB
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • jrockowitz authored a8f8d76 on 8.x-5.x 
    Issue #3243565 by jrockowitz, iyyappan.govind: Removed the usage of Yaml...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Reviewed & tested by the community » Fixed

  • jrockowitz authored 79ec088 on 8.x-5.x 
    Issue #3243565 by jrockowitz, iyyappan.govind: Removed the usage of Yaml...

  • jrockowitz authored 02dccf1 on 6.x 
    Issue #3243565 by jrockowitz, iyyappan.govind: Removed the usage of Yaml...
  • jrockowitz authored a8f8d76 on 6.x
    Issue #3243565 by jrockowitz, iyyappan.govind: Removed the usage of Yaml...

  • jrockowitz authored 79ec088 on 6.x 
    Issue #3243565 by jrockowitz, iyyappan.govind: Removed the usage of Yaml...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.