This is a requirement for #3177296: [META] Make Olivero stable. We need to mark the Olivero theme as stable when the time comes.

As far as I know, this should be as simple as removing experimental: true from olivero.info.yml at https://git.drupalcode.org/project/drupal/-/blob/9.3.x/core/themes/olive...

Issue fork drupal-3243041

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Issue tags: +Olivero stable blocker
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

The last stable blocker is landed in #3177296: [META] Make Olivero stable, does that mean its time for this one?

Gábor Hojtsy opened merge request !1314

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Made an MR with the update. *Maybe* I got a bit carried away in the info file, but I think the improvements are worthwhile. We can break those out to another issue to not disrupt the landing of stability though if others don't agree.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented

The last stable blocker is landed in #3177296: [META] Make Olivero stable, does that mean its time for this one?

#3173877: [meta] QA testing of Olivero across multiple browsers is currently still listed as a must-have in #3177296: [META] Make Olivero stable and is tagged with "Olivero stable blocker". Not sure how much testing we want to require prior to marking it stable.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented

Not sure how much testing we want to require prior to marking it stable.

Yep. We still need to do some formal browser testing, as a final-final-final check. I'm in the process of writing up the requirements for testing, and discussed with @lauriii earlier the approval steps.

I don't anticipate any blocking issues (I've personally tested with browsers such as Samsung Internet and Opera Mobile).

I hope to get this done by the end of the week.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

I undid all the unnecessary info.yml file changes, we can debate them elsewhere if desired.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented

Thanks! This looks good to me, and I'm willing to RTBC it when necessary!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Looks ready to go.

larowlan made their first commit to this issue’s fork.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉 Fixed 🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.