Problem/Motivation

shortcut_preprocess_page_title() causes deprecations on PHP 8.1 due to passing NULL into trim(strip_tags($name))

Steps to reproduce

Run \Drupal\Tests\shortcut\Functional\ShortcutLinksTest on PHP 8.1

Proposed resolution

Fix the method to handle NULLs better.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3241271-2.patch611 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
3241271-2.patch611 bytes

Before

PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.0RC3-dev
Configuration: /Users/alex/dev/sites/drupal8alt.dev/phpunit.xml
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing Drupal\Tests\shortcut\Functional\ShortcutLinksTest
......E...                                                        10 / 10 (100%)

Time: 01:30.089, Memory: 12.00 MB

There was 1 error:

1) Drupal\Tests\shortcut\Functional\ShortcutLinksTest::testNoShortcutLink
Exception: Deprecated function: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated
shortcut_preprocess_page_title()() (Line: 265)


/Users/alex/dev/sites/drupal8alt.dev/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:49
/Users/alex/dev/sites/drupal8alt.dev/vendor/guzzlehttp/promises/src/Promise.php:204
/Users/alex/dev/sites/drupal8alt.dev/vendor/guzzlehttp/promises/src/Promise.php:153
/Users/alex/dev/sites/drupal8alt.dev/vendor/guzzlehttp/promises/src/TaskQueue.php:48
/Users/alex/dev/sites/drupal8alt.dev/vendor/guzzlehttp/promises/src/Promise.php:248
/Users/alex/dev/sites/drupal8alt.dev/vendor/guzzlehttp/promises/src/Promise.php:224
/Users/alex/dev/sites/drupal8alt.dev/vendor/guzzlehttp/promises/src/Promise.php:269
/Users/alex/dev/sites/drupal8alt.dev/vendor/guzzlehttp/promises/src/Promise.php:226
/Users/alex/dev/sites/drupal8alt.dev/vendor/guzzlehttp/promises/src/Promise.php:62
/Users/alex/dev/sites/drupal8alt.dev/vendor/guzzlehttp/guzzle/src/Client.php:182
/Users/alex/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/DrupalTestBrowser.php:137
/Users/alex/dev/sites/drupal8alt.dev/vendor/symfony/browser-kit/Client.php:404
/Users/alex/dev/sites/drupal8alt.dev/vendor/friends-of-behat/mink-browserkit-driver/src/BrowserKitDriver.php:145
/Users/alex/dev/sites/drupal8alt.dev/vendor/behat/mink/src/Session.php:148
/Users/alex/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/UiHelperTrait.php:334
/Users/alex/dev/sites/drupal8alt.dev/core/modules/shortcut/tests/src/Functional/ShortcutLinksTest.php:337
/Users/alex/dev/sites/drupal8alt.dev/vendor/phpunit/phpunit/src/Framework/TestResult.php:722

After

PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.0RC3-dev
Configuration: /Users/alex/dev/sites/drupal8alt.dev/phpunit.xml
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing Drupal\Tests\shortcut\Functional\ShortcutLinksTest
..........                                                        10 / 10 (100%)

Time: 01:26.220, Memory: 12.00 MB

OK (10 tests, 300 assertions)
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed 9c2be57 and pushed to 9.3.x. Thanks!

  • larowlan committed 9c2be57 on 9.3.x 
    Issue #3241271 by alexpott: shortcut_preprocess_page_title() causes...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.