Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
\Drupal\tour\TipPluginBase::getLocation
causes deprecations on PHP 8.1 because of expecting that $location
is string (but it could be null)
See #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves) and commit https://git.drupalcode.org/project/drupal/-/commit/b1e8cb8326a31194baa92... for credits
Steps to reproduce
Run core/modules/views_ui/tests/src/Functional/ViewsUITourTest.php
on PHP 8.1
Exception : Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated
Drupal\tour\TipPluginBase->getLocation()() (Line: 162)
Proposed resolution
Fix \Drupal\tour\TipPluginBase::getLocation()
to handle null properly in trim()
Remaining tasks
review/commit
User interface changes
no
API changes
no
Data model changes
no
Release notes snippet
no
Comment | File | Size | Author |
---|---|---|---|
#2 | 3240362-2.patch | 527 bytes | andypost |
Comments
Comment #2
andypostPatch from commit
Comment #3
daffie CreditAttribution: daffie commentedLooks good to me.
Comment #4
alexpottCommitted 3265a80 and pushed to 9.3.x. Thanks!