Problem/Motivation

\Drupal\block\Plugin\migrate\process\BlockTheme::transform() can cause deprecation because $admin_theme is not always set.

Steps to reproduce

Run \Drupal\Tests\block\Kernel\Migrate\d6\MigrateBlockContentTranslationTest on PHP 8.1

Proposed resolution

Check it is set before passing to a string function.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3240165-2.patch735 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Priority: Normal » Critical
Status: Active » Needs review
FileSize
3240165-2.patch735 bytes

Here's the fix from the meta.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

  • catch committed bbb0d6c on 9.3.x 
    Issue #3240165 by alexpott: \Drupal\block\Plugin\migrate\process\...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed bbb0d6c and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.