Problem/Motivation

Hello, is there is any reason why the requirement for drupal/core is locked to ~9.0 (>=9.0.0 <9.1.0) in composer.json? On the other side, there is no such dependency in vartheme_bs4.info.yml (core_version_requirement: ^8 || ^9)... This blocks the projects from being upgraded to 9.2.x or so...

Proposed resolution

The drupal/core:~9.0 is working in many projects at this time with core_version_requirement: ^8 || ^9
Have you had a look at Composer Versions and constraints

Tilde Version Range (~)

Note: The ~ operator has an exception on its behavior for the major release number. This means for example that ~1 is the same as ~1.0 as it will not allow the major number to increase trying to keep backwards compatibility.

Hopping that all have a smooth upgrade from Drupal 8 to Drupal 9 as

Drupal 8 end-of-life on November 2, 2021 - PSA-2021-2021-06-29

Updating from Varbase 8.x to 9.x

Check out Varbase documentation for more details on Update Guides.

Quick fix with "drupal/core": "~8.0 || ~9.0", to ease work on old themes or sub-themes.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Quick fix with "drupal/core": "~8.0 || ~9.0", to ease work on old themes or sub-themes.
  • ✅ Testing to ensure no regression
  • ✅ Automated unit/functional testing coverage
    4 Oct 2021 at 18:45 EEST
  • ✅ Developer Documentation support on feature change/addition
  • ❌ User Guide Documentation support on feature change/addition
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release vartheme_bs4-8.x-6.32

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dejan0 created an issue. See original summary.

Rajab Natshah’s picture

Issue tags: -Drupal 9 compatibility

Thank you, dejan0 for reporting and the MR

Vartheme BS4 9.0.7 was released 14 Sep 2021 at 12:32 EEST
https://www.drupal.org/project/vartheme_bs4/releases/9.0.7

It is the right one to use with Drupal 9
The 9.0.x is the actively maintained branch

Drupal 8 end-of-life on November 2, 2021 - PSA-2021-2021-06-29

Please switch from Vartheme BS4 8.x-6.x branch to the Vartheme BS4 9.0.x branch
It is the same code and logic, but made to work better and inline with Drupal 9

Rajab Natshah’s picture

Assigned: Unassigned » Mohammed J. Razem
Status: Active » Needs review
Rajab Natshah’s picture

Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Varbase 9.0.1 was released 4 Aug 2021 at 21:56 EEST
https://www.drupal.org/project/varbase/releases/9.0.1

Updating from Varbase 8.x to 9.x

Check out Varbase documentation for more details on Update Guides.

dejan0’s picture

Okay, thanks, but I already checked Varbase theme 9.0.x version, and it also has a dependency on drupal/core:~9.0...

https://git.drupalcode.org/project/vartheme_bs4/-/blob/9.0.7/composer.js...

Rajab Natshah’s picture

dejan0 thanks for following up

The drupal/core:~9.0 is working in many projects at this time with core_version_requirement: ^9
Have you had a look at Composer Versions and constraints

Tilde Version Range (~)

Note: The ~ operator has an exception on its behavior for the major release number. This means for example that ~1 is the same as ~1.0 as it will not allow the major number to increase trying to keep backwards compatibility.

Hopping that all have a smooth upgrade from Drupal 8 to Drupal 9 as

Drupal 8 end-of-life on November 2, 2021 - PSA-2021-2021-06-29

Updating from Varbase 8.x to 9.x

Check out Varbase documentation for more details on Update Guides.

dejan0’s picture

ahh ok, thanks @rajabnatshah, so vartheme_bs4:9.x solved a problem.

Rajab Natshah’s picture

Very good :)
Closing this issue!?

But it's good to commit this basic change to ease work on old themes or sub-themes.

"drupal/core": "~8.0 || ~9.0",

Rajab Natshah’s picture

Assigned: Unassigned » Rajab Natshah
Status: Needs review » Active
Rajab Natshah’s picture

Title: Support for drupal/core >= 9.1 is missing ? » Fix Support for drupal/core >= 9.1 is missing in the 8.x-6.x-dev branch, Use the vartheme_bs4 9.0.x branch

  • RajabNatshah committed 9b76a97 on 8.x-6.x authored by dejan0
    Issue #3240119 by dejan0: Fix Support for drupal/core >= 9.1 is missing...

  • RajabNatshah committed 7228c7d on 8.x-6.x
    Issue #3240119 by dejan0: Fix Support for drupal/core >= 9.1 is missing...
Rajab Natshah’s picture

Issue summary: View changes

  • RajabNatshah committed 40ef5c3 on 8.x-6.x
    Issue #3240119 by dejan0: Fix Support for drupal/core >= 9.1 is missing...

  • RajabNatshah committed 7d0a5d4 on 8.x-6.x
    Issue #3240119 by dejan0: Fix Support for drupal/core >= 9.1 is missing...

  • RajabNatshah committed 7ae5645 on 8.x-6.x
    Issue #3240119 by dejan0: Fix Support for drupal/core >= 9.1 is missing...

  • RajabNatshah committed f4d48e1 on 8.x-6.x
    Issue #3240119 by dejan0: Fix Support for drupal/core >= 9.1 is missing...
Rajab Natshah’s picture

Assigned: Rajab Natshah » Mohammed J. Razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-8.8.12, +vartheme_bs4-8.x-6.32
4 Oct 2021 at 18:45 EEST
Rajab Natshah’s picture

Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Status: Needs review » Fixed
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.