Problem/Motivation

Remove the negative expression from the checkbox description that appears on hover, to avoid the user’s confusion.

Issue fork cloud-3236437

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TamakiFujino created an issue. See original summary.

TamakiFujino opened merge request !405

mohit.bansal623’s picture

mohit.bansal623 CreditAttribution: mohit.bansal623 as a volunteer and at Axelerant commented
Status: Active » Needs review

As the merge request is already created, moving it to review.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Title: Fix the UI/UX of Cloud Service Providers (5) (Checkbox) » Refactor the UI/UX of Cloud Service Providers (5) (Checkbox)
Status: Needs review » Needs work

@tamakifujino

Thank you for refactoring. I posted my comment above. Please check. Thanks!

mohit.bansal623’s picture

mohit.bansal623 CreditAttribution: mohit.bansal623 as a volunteer and at Axelerant commented

It looks good.

TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented

@yas

To me Test only when checked sounds not a full sentence because 'test only' is probably a noun in this case.
- Test-only / when checked.

If we use 'test' as verb,
- Test / only when checked. It will avoid a new instance from launching for testing.

However, in this case, it is unclear what to test. If the checkbox means the form will be test version. you probably want to say:
Use this AWS Cloud as test (version/mode). It will avoid a new instance from launching.

Although I am not 100% confident with my grammar and the purpose of the checkbox, I think it is still unclear when we say test only when checked

Please let me know what the checkbox supposed to do, or any opinion on this.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@tamakifujino

Thank you for your suggestion. I posted my comment, what about this one?

'Enable test mode when checked. It will avoid a new instance from launching for testing.'

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Reviewed & tested by the community

@tamakifujino

As we discussed, I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed a5e8647 on 4.x authored by TamakiFujino 
    Issue #3236437 by TamakiFujino, yas, mohit.bansal623: Refactor the UI/UX...

yas closed merge request !405

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.