Problem/Motivation

Right now, the staging directory can be non-writable by the web server because of security measures Drupal core takes. We are working around this problem during the commit stage of the update, but once the update succeeds, an exception can happen if the staged sites/default -- which is no longer needed, once the update has been committed -- is not writable.

Steps to reproduce

It's not clear how to reproduce this consistently, but if you run the build tests locally, it can happen to you. The update will succeed, but the test will fail because you'll get an exception before you reach the "Update complete!" page.

Proposed resolution

In Updater::update(), make the stage directory's sites/default writable if it isn't already. If it can't be made writable, throw an exception.

Remaining tasks

Do it with tests.

User interface changes

None.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

tedbow’s picture

Status: Active » Reviewed & tested by the community

RTBC

  • phenaproxima committed e34cd75 on 8.x-2.x
    Issue #3231992 by phenaproxima: Make the staged sites/default writable...
phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.