We have a couple usages of --color--blue-50
in text (see the RSS icon's hover state). We need to make sure we're not using these as it doesn't provide a 4.5:1 contrast ratio required to be WCAG compliant.
In #3211616: Olivero: a11y color contrast test fail for primary button on hover we introduce a new variable --color--blue-10
. We can use that, or the existing --color--blue-20
variable.
Comment | File | Size | Author |
---|---|---|---|
#2 | 3231744-2.patch | 43.22 KB | Gauravvvv |
Issue fork drupal-3231744
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedReplaced the color variable
--color--blue-50
with--color--blue-10
in patch #2, Please review.Comment #3
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedComment #4
mherchelWe don't need to make the change everywhere, only where it doesn't meet contrast criteria. This means we don't need to change borders, outlines, etc. We also don't need to change it if the text is larger than 19px bold too.
Comment #6
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedComment #7
mherchelAs part if #3242469: Insufficient contrast on Olivero's inactive vertical form labels, we also need to make sure that the new text color provides sufficient contrast in the inactive vertical form labels.
Comment #11
smustgrave CreditAttribution: smustgrave at Mobomo commentedMR needs to be updated to 10.1 please.
Comment #12
mgiffordAdding tag for WCAG SC 1.4.3