Problem/Motivation

Ran into an issue when trying the module.

Steps to reproduce

1. Using Drupal 9.2.5 (Standard install, fresh)
2. Installed the CKEditor 5 module (via git clone ...)
3. Go to Text formats and editors -> Basic HTML
4. Changing from CKEditor 4 to CKEditor 5.
5. Try to save, get an error about Image Upload plugin, removing that plugin and saving the text format.
6. When going to to node/add/page, I get the following in the console:

CKEditorError: plugincollection-plugin-not-found {"plugin":null}
Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-plugincollection-plugin-not-found
    at ckeditor5-dll.js?v=29.0.0:5
    at ckeditor5-dll.js?v=29.0.0:5
    at Array.forEach (<anonymous>)
    at u (ckeditor5-dll.js?v=29.0.0:5)
    at m.init (ckeditor5-dll.js?v=29.0.0:5)
    at P.initPlugins (ckeditor5-dll.js?v=29.0.0:5)
    at editor-classic.js?v=29.0.0:5
    at new Promise (<anonymous>)
    at Function.create (editor-classic.js?v=29.0.0:5)
    at Object.attach (js_oq5vm4mRtyRbIKIjrL30C9Qni12msdcZNxDKSHUOqls.js:292)

Did try some cache rebuilds, and resaving the text format without any luck.

Interestingly enough, when I create a new text format using CKEditor 5, the Basic HTML one starts working.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor5-3231427

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

johnwebdev created an issue. See original summary.

johnwebdev’s picture

Issue summary: View changes
Wim Leers’s picture

Priority: Normal » Critical

Reproduced. Thanks for reporting! 🙏

lauriii made their first commit to this issue’s fork.

lauriii’s picture

Status: Active » Needs review

The root cause for the problem is that our source editing integration requires htmlSupport plugin since #3222852: <dl> <dt> <dd> by introducing "Manually editable HTML tags" configuration on Source Editing. However, htmlSupport wasn't added as a dependency there. What I did was I simply added htmlSupport dependency of the sourceEditing library. While in theory sourceEditing plugin doesn't depend on htmlSupport, it seems like a pragmatic way to solve this. Alternative would be to add a new library which depends on both, htmlSupport and sourceEditing. This way it would be still possible to load sourceEditing without loading htmlSupport.

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

This solution is perfect! 👍

Alternative would be to add a new library which depends on both, htmlSupport and sourceEditing. This way it would be still possible to load sourceEditing without loading htmlSupport.

There's no need for that IMHO. We've tied specific functionality to the Source Editing CKE5 plugin in Drupal, with support/blessing from the CKEditor 5 maintainers.

Wim Leers’s picture

Status: Reviewed & tested by the community » Fixed

  • Wim Leers committed 14c4ca6 on 1.0.x authored by lauriii
    Issue #3231427 by lauriii, johnwebdev: Changing basic HTML format to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.