Problem/Motivation

The current CKEditor admin UI is dependent on the performance of ajax requests. Instead of re-rendering the UI via ajax, render the changes in the UI independent from the ajax requests. However, that requires some improvements to the way the ajax requests are handled to ensure that what is in the form value is represented properly in the UI. This means that consecutive requests and errors should be handled by the UI.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor5-3230447

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

Wim Leers made their first commit to this issue’s fork.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
Parent issue: » #3227853: Remove dependency on Vue.js
Related issues: +#3218985: CKEditor 5 admin UI's AJAX logic and form alterations are too complex and brittle

My working on #3218985: CKEditor 5 admin UI's AJAX logic and form alterations are too complex and brittle has helped here, and in fact, the solution for the server side portion here is something that will help #3218985: CKEditor 5 admin UI's AJAX logic and form alterations are too complex and brittle :)

lauriii opened merge request !102

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Failed due to:

Exception: Array
(
    [0] => Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for editor.editor.ckeditor5 with the following errors: editor.editor.ckeditor5:settings.is_already_using_ckeditor5 missing schema in Drupal\Core\Config\Development\ConfigSchemaChecker-…
    [1] => Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for editor.editor.ckeditor5 with the following errors: editor.editor.ckeditor5:settings.is_already_using_ckeditor5 missing schema in Drupal\Core\Config\Development\ConfigSchemaChecker-…
)

… which makes total sense. Also explains why I didn't run into this locally: strict config schema validation is only enabled for tests.

Let's see how it does now :)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Assigned: Unassigned » Wim Leers

Yay, green!

Assigning to @lauriii for his final review, and adding a comment or two :)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Assigned: Wim Leers » lauriii

Assigning to @lauriii for his final review, and adding a comment or two :)

… and in doing so I assigned it to myself — LOL!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

  • Wim Leers committed d53f059 on 1.0.x authored by lauriii 
    Issue #3230447 by lauriii, Wim Leers: Improve CKEditor admin UI...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Reviewed & tested by the community » Fixed
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

This introduced a regression: #3231289: Follow-up for #3230447: since optimizing admin UI, messages can accumulate.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.