Problem/Motivation

Per #3070430: Incompatible with JSON:API Extras, modules such as JSON:API cross bundles also decorate the resource type repository, but jsonapi_extras' typehints and business logic isn't friendly to such extension. This is relatively easily addressed by typehinting against the repository's interface, and doing some special handling around the configuration table to gracefully disable configuring these resource types.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bradjones1 created an issue. See original summary.

bradjones1’s picture

Status: Active » Needs review
bradjones1’s picture

GuyPaddock’s picture

Status: Needs review » Needs work
GuyPaddock’s picture

@bbrala: I addressed your comments about static vs. self, but I'm not 100% sure if that accomplishes what @bradjones1 was after. Is it possible that we want this to be static across all the instances regardless of class, to allow multiple sub-classes to share the same cache of resource configs? I'm also not sure what the benefit to doing that is because this issue is supposed to make it possible to decorate the JSON:API Extras version of the resource repository, correct? So, wouldn't there only ever be one instance of this specific type of repository (the rest would not be extending this code)?

Regardless, I fixed the PHP Notice with the reset() and rebased on top of 3.x dev so that this is mergeable again. I wasn't sure about the other feedback from bbrala so I'm leaving this as NW for @bradjones1 to comment.

bbrala’s picture

(comment so my avatar shows ;))

bradjones1’s picture

Re-rolled but now there is a test failure that I would need to recreate locally/look at closer.

bradjones1’s picture

Status: Needs work » Needs review

  • bbrala committed 3b321b2 on 8.x-3.x authored by bradjones1
    Issue #3229890 by bradjones1, GuyPaddock, bbrala: Better compatibility...
bbrala’s picture

Thanks for the contribution! :) Sorry for taking so long to finish up this review.

bradjones1’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.