Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#5 | mysql56-9.3-5.patch | 419 bytes | effulgentsia |
#2 | mysql56-9.3.patch | 403 bytes | effulgentsia |
Comments
Comment #2
effulgentsia CreditAttribution: effulgentsia at Acquia commentedComment #3
effulgentsia CreditAttribution: effulgentsia at Acquia commentedComment #4
balsamaI've never seen the `-` operator before. Why not:
"drupal/core": "~9.0.0-beta3 || 9.1.* || 9.2.* || 9.3.*"
? It's a little more verbose, but it's super clear what it does. OR even>=9.0.0-beta3 <9.4
.I don't have a strong preference, but I think either of those is slightly easier to understand. All behave identically according to https://jubianchi.github.io/semver-check/. But all also seem to allow 9.0.0-beta2 (and other tagged 9.0.0 releases prior to beta3 including the alphas). If this is true, it's a separate and existing bug.
Comment #5
effulgentsia CreditAttribution: effulgentsia at Acquia commentedThanks for the review. Ok, here's the more explicit, less clever way. We can open a separate issue to replace this with a more idiomatic way of specifying a range if we want to.
Comment #6
effulgentsia CreditAttribution: effulgentsia at Acquia commentedHere's that other issue: #3229663: Specify the drupal/core range constraint more idiomatically
Comment #7
TravisCarden CreditAttribution: TravisCarden commentedThey're also functionally equivalent as tested directly against Packagist:
Comment #8
balsamaThanks for the additional checker, @TravisCarden. Marking as RTBC.
Comment #10
effulgentsia CreditAttribution: effulgentsia at Acquia commentedThanks!