Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 mysql56-9.3-5.patch419 byteseffulgentsia
#2 mysql56-9.3.patch403 byteseffulgentsia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

effulgentsia created an issue. See original summary.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
FileSize
mysql56-9.3.patch403 bytes
effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Status: Active » Needs review
balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented

I've never seen the `-` operator before. Why not: "drupal/core": "~9.0.0-beta3 || 9.1.* || 9.2.* || 9.3.*"? It's a little more verbose, but it's super clear what it does. OR even >=9.0.0-beta3 <9.4.

I don't have a strong preference, but I think either of those is slightly easier to understand. All behave identically according to https://jubianchi.github.io/semver-check/. But all also seem to allow 9.0.0-beta2 (and other tagged 9.0.0 releases prior to beta3 including the alphas). If this is true, it's a separate and existing bug.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
FileSize
mysql56-9.3-5.patch419 bytes

Thanks for the review. Ok, here's the more explicit, less clever way. We can open a separate issue to replace this with a more idiomatic way of specifying a range if we want to.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Related issues: +#3229663: Specify the drupal/core range constraint more idiomatically

Here's that other issue: #3229663: Specify the drupal/core range constraint more idiomatically

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented

All behave identically according to https://jubianchi.github.io/semver-check/.

They're also functionally equivalent as tested directly against Packagist:

  1. https://semver.mwl.be/?package=drupal%2Fcore&constraint=9.0.0-beta3%20-%...
  2. https://semver.mwl.be/?package=drupal%2Fcore&constraint=%3E%3D9.0.0-beta...
balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
Status: Needs review » Reviewed & tested by the community

Thanks for the additional checker, @TravisCarden. Marking as RTBC.

  • effulgentsia committed af6814c on 8.x-1.x 
    Issue #3229492 by effulgentsia, balsama, TravisCarden: Add support for...
effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.