Fix D9 test fails [#3229472]

See https://www.drupal.org/pift-ci-job/2153692

Comment	File	Size	Author
#15	3229472-15.patch	12.19 KB	alexpott
#15	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9.20 174 pass, 4 fail PHP 7.4 & MySQL 5.7, D9.2 176 pass PHP 7.3 & MySQL 5.7, D9.3 125 pass, 30 fail PHP 7.3 & PostgreSQL 9.5, D8.9.20 170 pass, 2 fail PHP 7.4 & MySQL 8, D8.9.20 176 pass PHP 7 & MySQL 5.5, D8.9.20 run-tests.sh fatal error PHP 7 & SQLite 3.14, D8.9.20 run-tests.sh fatal error
#15	13-15-interdiff.txt	717 bytes	alexpott
#13	3229472-13.patch	12.2 KB	alexpott
#13	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9.20 168 pass, 6 fail PHP 7.3 & MySQL 8, D9.2 170 pass, 2 fail
#13	9-13-interdiff.txt	2.42 KB	alexpott
#9	paragraphs_3229472_7.patch	12.14 KB	sleitner
#9	8.x-1.x: PHP 7.4 & MySQL 8, D9.2.0 176 pass PHP 7.2 & MySQL 5.7, D8.9.16 176 pass
#8	paragraphs_3229472_6.patch	12.14 KB	sleitner
#8
#6	paragraphs_3229472_6.patch	12.14 KB	sleitner
#6	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 174 pass, 4 fail PHP 7.4 & MySQL 8, D9.2.0 176 pass PHP 7.2 & MySQL 5.5, D8.9.16 174 pass, 4 fail PHP 7.2 & MySQL 5.7, D8.9 176 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

23 August 2021 at 14:41

mathilde_dumond created an issue. See original summary.

Comment #2

mathilde_dumond CreditAttribution: mathilde_dumond at MD Systems GmbH commented 23 August 2021 at 14:47

Title:	ParagraphsAdministrationTest test fail	» ParagraphsAdministrationTest test fail on 9.2
Status:	Needs work	» Postponed

Comment #3

mathilde_dumond CreditAttribution: mathilde_dumond at MD Systems GmbH commented 23 August 2021 at 14:53

Comment #4

mathilde_dumond CreditAttribution: mathilde_dumond at MD Systems GmbH commented 23 August 2021 at 14:55

Title:	ParagraphsAdministrationTest test fail on 9.2	» Fix D9 test fails
Issue summary:	View changes

Problem/Motivation

Creating this issue after a test fail here https://www.drupal.org/pift-ci-job/2155358 on ParagraphsAdministrationTest.

I ran the test locally (on top of Drupal 9.2) and it failed as well on a clean install.

The error is: The string "<a href="http://drupal.local/sites/simpletest/81722527/files/2021-08/image-test.png" type="image/png; length=125">image-test.png</a>" was not found anywhere in the HTML response of the current page. whereas the actual string is <a href="http://drupal.local/sites/simpletest/81722527/files/2021-08/image-test.png" type="image/png">image-test.png</a> so I am guessing that this could be linked to the Media changes that we are seeing in core?

From https://www.drupal.org/pift-ci-job/2155358 I see that the last success was in May and 8.9 got some changes in the meantime.

Steps to reproduce

Proposed resolution

update the test string to <a href="http://drupal.local/sites/simpletest/81722527/files/2021-08/image-test.png" type="image/png">image-test.png</a> (the actual string from the test)

Comment #5

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 24 August 2021 at 06:16

Status:

Postponed

» Active

did some digging. these assertions go back a very long time, seems to be part of the very first version of that test that one of our first ever students did, that was before john was working for us, although he did work on that test once as well

I would propose that we simplify that and just assert for the image url, we don't have to test core markup that not even core itself was testing for.

Comment #6

sleitner CreditAttribution: sleitner commented 12 November 2021 at 23:23

Status:

Active

» Needs review

File	Size
paragraphs_3229472_6.patch	12.14 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 174 pass, 4 fail PHP 7.4 & MySQL 8, D9.2.0 176 pass PHP 7.2 & MySQL 5.5, D8.9.16 174 pass, 4 fail PHP 7.2 & MySQL 5.7, D8.9 176 pass

Comment #7

12 November 2021 at 23:42

Status:

Needs review

» Needs work

The last submitted patch, 6: paragraphs_3229472_6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #8

sleitner CreditAttribution: sleitner commented 13 November 2021 at 11:16

File	Size
paragraphs_3229472_6.patch	12.14 KB

Comment #9

sleitner CreditAttribution: sleitner commented 13 November 2021 at 11:16

File	Size
paragraphs_3229472_7.patch	12.14 KB
8.x-1.x: PHP 7.4 & MySQL 8, D9.2.0 176 pass PHP 7.2 & MySQL 5.7, D8.9.16 176 pass

Comment #10

sleitner CreditAttribution: sleitner commented 13 November 2021 at 11:47

Status:

Needs work

» Needs review

Replaced some asserts with more general ones to fit with both Drupal 8 and 9.

There is currently a problem in search_api which leads to the failure with Mysql 5.5: https://www.drupal.org/project/search_api/issues/3247781

Comment #11

sleitner CreditAttribution: sleitner commented 18 November 2021 at 16:45

Comment #12

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce, Thunder commented 14 December 2021 at 16:48

+++ b/tests/src/Functional/WidgetLegacy/ParagraphsConfigTest.php
@@ -214,8 +214,8 @@ class ParagraphsConfigTest extends ParagraphsTestBase {
-    $this->assertSession()->pageTextContains('Add paragraph_type_test');
-    $this->assertSession()->pageTextNotContains('Add text');
+    $this->assertSession()->responseContains('Add paragraph_type_test');
+    $this->assertSession()->responseNotContains('Add text');

@@ -237,8 +237,8 @@ class ParagraphsConfigTest extends ParagraphsTestBase {
-    $this->assertSession()->pageTextContains('Add paragraph_type_test');
-    $this->assertSession()->pageTextNotContains('Add text');
+    $this->assertSession()->responseContains('Add paragraph_type_test');
+    $this->assertSession()->responseNotContains('Add text');
   }

+++ b/tests/src/Functional/WidgetStable/ParagraphsConfigTest.php
@@ -182,7 +182,7 @@ class ParagraphsConfigTest extends ParagraphsTestBase {
-    $this->assertSession()->pageTextContains('Add paragraph_type_test');
+    $this->assertSession()->responseContains('Add paragraph_type_test');
     $this->assertSession()->pageTextNotContains('Add text');

@@ -229,8 +229,8 @@ class ParagraphsConfigTest extends ParagraphsTestBase {
-    $this->assertSession()->pageTextContains('Add paragraph_type_test');
-    $this->assertSession()->pageTextNotContains('Add text');
+    $this->assertSession()->responseContains('Add paragraph_type_test');
+    $this->assertSession()->responseNotContains('Add text');

These are button texts... at least the positive assertion could be $this->assertSession()->buttonExists('Add paragraph_type_test');

Comment #13

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce, Thunder commented 14 December 2021 at 16:52

File	Size
9-13-interdiff.txt	2.42 KB
3229472-13.patch	12.2 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9.20 168 pass, 6 fail PHP 7.3 & MySQL 8, D9.2 170 pass, 2 fail

Like this.

Comment #14

14 December 2021 at 17:12

Status:

Needs review

» Needs work

The last submitted patch, 13: 3229472-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #15

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce, Thunder commented 14 December 2021 at 17:55

Status:

Needs work

» Needs review

File	Size
13-15-interdiff.txt	717 bytes
3229472-15.patch	12.19 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9.20 174 pass, 4 fail PHP 7.4 & MySQL 5.7, D9.2 176 pass PHP 7.3 & MySQL 5.7, D9.3 125 pass, 30 fail PHP 7.3 & PostgreSQL 9.5, D8.9.20 170 pass, 2 fail PHP 7.4 & MySQL 8, D8.9.20 176 pass PHP 7 & MySQL 5.5, D8.9.20 run-tests.sh fatal error PHP 7 & SQLite 3.14, D8.9.20 run-tests.sh fatal error

Whoops

Comment #16

14 December 2021 at 18:10

Status:

Needs review

» Needs work

The last submitted patch, 15: 3229472-15.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #17

14 December 2021 at 19:59

Berdir committed 0cbc562 on 8.x-1.x authored by sleitner

Issue #3229472 by sleitner, alexpott: Fix D9 test fails

Comment #18

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 14 December 2021 at 20:00

Status:

Needs work

» Fixed

Well, that's at least some green :)

Will update the test configuration after this to more recent PHP versions and D9 only.

+++ b/paragraphs.info.yml
@@ -15,3 +15,7 @@ test_dependencies:
   - block_field:block_field
+  - search_api:search_api_db
+  - entity_usage:entity_usage
+  - ctools:ctools
+  - entity_browser:entity_browser

I don't bother updating test dependencies, it doesn't work in patches and merge requests anyway. Committed without that part.