Short array syntax must be used to define arrays
(Drupal.Arrays.DisallowLongArraySyntax.Found)

There must be exactly one blank line before the tags in a doc comment
(Drupal.Commenting.DocComment.SpacingBeforeTags)

Expected 1 space after FUNCTION keyword; 0 found
(Squiz.Functions.MultiLineFunctionDeclaration.SpaceAfterFunction)

Description for the @return value is missing
(Drupal.Commenting.FunctionComment.MissingReturnComment)

Doc comment short description must end with a full stop
(Drupal.Commenting.DocComment.ShortFullStop)

Array closing indentation error, expected 4 spaces but found 6
(Drupal.Arrays.Array.ArrayClosingIndentation)

The closing brace for the class must have an empty line before it
(Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
CommentFileSizeAuthor
#2 monolog-fix_drupal_coding_standard_and_drupal_practice-3228951-14195268-8.x-1.x.patch8.75 KBomrmankar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

omrmankar created an issue. See original summary.

omrmankar’s picture

omrmankar
Primary language English
Location Mumbai, Maharashtra
CreditAttribution: omrmankar at OpenSense Labs commented
Assigned: omrmankar » Unassigned
Status: Needs work » Needs review
FileSize
monolog-fix_drupal_coding_standard_and_drupal_practice-3228951-14195268-8.x-1.x.patch8.75 KB

Hi,

I have created a patch that is working according to the phpcs standards and resolves all errors.

The patch is attached.

  • lussoluca committed 9a9a429 on 2.x 
    Issue #3251624
Issue #3246910
Issue #3245874
Issue #3228951
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca commented
Status: Needs review » Fixed

Committed and pushed to 2.x-dev. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.