Problem/Motivation

When running test, ParagraphsTypeHasEnabledBehaviorPluginTest. ::setUp should have a void return typehint.

Steps to reproduce

Proposed resolution

Adding a void typehint to ::setUp.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 3228098-void-4.patch2.27 KBtaniachque
#7 interdiff-3228098-1-4.txt1.9 KBtaniachque
#6 3228098-6.patch25.73 KBhmendes
#5 3228098_interdiff.txt18.89 KBhmendes
#5 3228098_5.patch21.15 KBhmendes
#4 3228098-void-4.patch2.26 KBmrinalini9
#2 3228098-void-1.patch2.26 KBtaniachque
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

taniachque created an issue. See original summary.

taniachque’s picture

taniachque CreditAttribution: taniachque at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
3228098-void-1.patch2.26 KB
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/tests/src/Kernel/ParagraphsBehaviorPluginsTest.php
@@ -31,7 +31,7 @@ class ParagraphsBehaviorPluginsTest extends KernelTestBase {
    * {@inheritdoc}
    */
-  protected function setUp() {
+  protected function setUp():void {
     parent::setUp();

Looking are core, the coding standard is to add a space between : and void.

mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3228098-void-4.patch2.26 KB

Updated patch #2 by adding space between : and void, please review it.

hmendes’s picture

hmendes CreditAttribution: hmendes at CI&T commented
FileSize
3228098_5.patch21.15 KB
3228098_interdiff.txt18.89 KB

Shouldn't we fix all occurrences of setIp in the tests?
Adding a new patch.

hmendes’s picture

hmendes CreditAttribution: hmendes at CI&T commented
FileSize
3228098-6.patch25.73 KB

Forgot to fix the submodules tests.

taniachque’s picture

taniachque CreditAttribution: taniachque at MD Systems GmbH commented
Assigned: Unassigned » taniachque
FileSize
interdiff-3228098-1-4.txt1.9 KB
3228098-void-4.patch2.27 KB

Thank you so much for the patches, I will fix the remaining notices.
I have this old patch that I wanted to upload.

mathilde_dumond’s picture

mathilde_dumond CreditAttribution: mathilde_dumond at MD Systems GmbH commented
Assigned: taniachque » Unassigned
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks, committed. This will likely break tests in modules that extend from paragraphs (base) test classes, paragraphs_collection for example will likely be affected.

  • Berdir committed 203ecf8 on 8.x-1.x authored by hmendes 
    Issue #3228098 by taniachque, hmendes, mrinalini9: ::setUp should have...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.