Problem/Motivation

AssertLegacyTrait::assertNoRaw() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->responseNotContains() instead. See https://www.drupal.org/node/3129738

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3227060

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !1023

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented

Remove deprecation silencer to see how many we have to convert.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Assigned: mondrake » Unassigned
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

The deprecation message supression has been removed.
All usage of assertNoRaw() has been replaced.
For me is it RTBC.

  • catch committed e33e4c7 on 9.3.x 
    Issue #3227060 by mondrake, daffie: Replace usages of AssertLegacyTrait...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Title: Replace usages of AssertLegacyTrait::assertNoRaw, that is deprecated » [backport] Replace usages of AssertLegacyTrait::assertNoRaw, that is deprecated
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Needs work

Committed e33e4c7 and pushed to 9.3.x. Thanks!

We should backport this to 9.2.x to help other patches - needs a re-roll for some hunks, and also the 9.2.x version should not remove the deprecation suppression.

mondrake closed merge request !1023

ankithashetty made their first commit to this issue’s fork.

ankithashetty opened merge request !1027

ankithashetty’s picture

ankithashetty
Location Karnataka, India
CreditAttribution: ankithashetty as a volunteer and at Specbee commented
Status: Needs work » Needs review

Re-rolled against 9.2.x branch and retained the deprecation message suppression. Kindly review, thanks!

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Needs work

I am missing the change to core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php. See: https://git.drupalcode.org/project/drupal/-/commit/e33e4c7?page=4

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review

@daffie we can't remove deprecation skips in a patch release of 9.2.x, this is the change that @catch asked for in #8.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

@longwave: Thanks for pointing it out. I missed it.

I did a side by side comparison of the commit and the MR and all the changes match up.
For me it is RTBC.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Title: [backport] Replace usages of AssertLegacyTrait::assertNoRaw, that is deprecated » Replace usages of AssertLegacyTrait::assertNoRaw, that is deprecated
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x, thanks!

  • catch committed cef0c90 on 9.2.x 
    Issue #3227060 by mondrake, ankithashetty, daffie, catch: [backport]...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.