Problem/Motivation

  • Check and align the comments at Drupal\k8s\Entity\K8s<ResourceName>ViewsData
  • The following is a list of CamelCase resource names (the other one is NOT CamelCame):
    • ConfigMaps
    • CronJob
    • DaemonSet
    • LimitRange
    • ReplicaSet
    • ServiceAccount
    • StatefulSet
  • See also the Glossary page: https://kubernetes.io/docs/reference/glossary/?all=true
  • Format:
    /**
     * Redirects to a K8s <ResourceName or Resource Name> form.
     *
     * @Action(
     *   id = "entity:delete_action:k8s_<resource_name>",
     *   label = @Translation("Delete <Resource Name or ResourceName>"),
     *   type = "k8s_<resource_name>"
     * )
     */
    
  • For example:
    /**
     * Redirects to a K8s ReplicaSet form.
     *
     * @Action(
     *   id = "entity:delete_action:k8s_replica_set",
     *   label = @Translation("Delete ReplicaSet"),
     *   type = "k8s_replica_set"
     * )
     */
    
    /**
     * Redirects to a K8s Network Policy form.
     *
     * @Action(
     *   id = "entity:delete_action:k8s_network_policy",
     *   label = @Translation("Delete Network Policy"),
     *   type = "k8s_network_policy"
     * )
     */
    

Issue fork cloud-3225417

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas’s picture

Issue summary: View changes

TamakiFujino made their first commit to this issue’s fork.

TamakiFujino’s picture

Assigned: Unassigned » TamakiFujino
Status: Active » Needs work

TamakiFujino’s picture

Status: Needs work » Needs review
yas’s picture

Status: Needs review » Needs work

@tamakifujino

Thank you for the refactoring. Let's remove K8s from the following comments, too:

 * Redirects to a K8s DaemonSet form.
 * Redirects to a K8s LimitRange form.
 * Redirects to a K8s ReplicaSet form.
 * Redirects to a K8s ServiceAccount form.
 * Redirects to a K8s StatefulSet form.
TamakiFujino’s picture

Status: Needs work » Needs review
yas’s picture

Status: Needs review » Needs work

@tamakifujino

Could you please double-check if the patch included my request comment #7 above? Please correct me if I'm wrong however I couldn't see any change in the current patch. Let us change the status Needs work for now.

Thanks

TamakiFujino’s picture

Status: Needs work » Needs review
yas’s picture

Status: Needs review » Reviewed & tested by the community

@tamakifujino

Thank you for the update. It looks perfect to me now. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 1a04639 on 4.x authored by TamakiFujino
    Issue #3225417 by TamakiFujino, yas: Align the comments at Drupal\k8s\...

yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.