Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
- Check and align the comments at
Drupal\k8s\Entity\K8s<ResourceName>ViewsData
- The following is a list of CamelCase resource names (the other one is NOT CamelCame):
ConfigMaps
CronJob
DaemonSet
LimitRange
ReplicaSet
ServiceAccount
StatefulSet
- See also the Glossary page: https://kubernetes.io/docs/reference/glossary/?all=true
- Format:
/** * Redirects to a K8s <ResourceName or Resource Name> form. * * @Action( * id = "entity:delete_action:k8s_<resource_name>", * label = @Translation("Delete <Resource Name or ResourceName>"), * type = "k8s_<resource_name>" * ) */
- For example:
/** * Redirects to a K8s ReplicaSet form. * * @Action( * id = "entity:delete_action:k8s_replica_set", * label = @Translation("Delete ReplicaSet"), * type = "k8s_replica_set" * ) */
/** * Redirects to a K8s Network Policy form. * * @Action( * id = "entity:delete_action:k8s_network_policy", * label = @Translation("Delete Network Policy"), * type = "k8s_network_policy" * ) */
Issue fork cloud-3225417
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3225417-align-the-comments changes, plain diff MR !389
Comments
Comment #2
yasComment #4
TamakiFujino CreditAttribution: TamakiFujino commentedComment #6
TamakiFujino CreditAttribution: TamakiFujino commentedComment #7
yas@tamakifujino
Thank you for the refactoring. Let's remove
K8s
from the following comments, too:Comment #8
TamakiFujino CreditAttribution: TamakiFujino commentedComment #9
yas@tamakifujino
Could you please double-check if the patch included my request comment #7 above? Please correct me if I'm wrong however I couldn't see any change in the current patch. Let us change the status Needs work for now.
Thanks
Comment #10
TamakiFujino CreditAttribution: TamakiFujino commentedComment #11
yas@tamakifujino
Thank you for the update. It looks perfect to me now. I'll merge the patch to
4.x
and close this issue as Fixed.Comment #14
yas