Problem/Motivation

  • Check and align comments at Drupal\k8s\Controller\ApiControllerInterface
  • The following is a list of CamelCase resource names (the other one is NOT CamelCame):
    • ConfigMaps
    • CronJob
    • DaemonSet
    • LimitRange
    • ReplicaSet
    • ServiceAccount
    • StatefulSet
  • See also the Glossary page: https://kubernetes.io/docs/reference/glossary/?all=true
  • Format:
    /**
       * Update all K8s <Resource Name or ResourceName>.
       *
       * @param string $cloud_context
       *   Cloud context string.
       *
       * @return \Symfony\Component\HttpFoundation\RedirectResponse
       *   A redirect response object that may be returned by the controller.
       */
    
  • For example:
      /**
       * Update all K8s LimitRanges.
       *
       * @param string $cloud_context
       *   Cloud context string.
       *
       * @return \Symfony\Component\HttpFoundation\RedirectResponse
       *   A redirect response object that may be returned by the controller.
       */
    
      /**
       * Update all K8s Network Policies.
       *
       * @param string $cloud_context
       *   Cloud context string.
       *
       * @return \Symfony\Component\HttpFoundation\RedirectResponse
       *   A redirect response object that may be returned by the controller.
       */
    

Issue fork cloud-3225218

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

kumikoono made their first commit to this issue’s fork.

kumikoono’s picture

Assigned: Unassigned » TamakiFujino
TamakiFujino’s picture

Please review

TamakiFujino’s picture

Status: Active » Needs work
TamakiFujino’s picture

Status: Needs work » Needs review
kumikoono’s picture

@tamaki The patch looks good to me. Thanks!

yas’s picture

Status: Needs review » Needs work

@tamakifujino

Thank you for supplying the patch. I posted a minor comment above. Please check it. Thanks!

yas’s picture

Status: Needs work » Reviewed & tested by the community

@tamakifujino

Thank you for the update. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed c14d03d on 4.x authored by TamakiFujino
    Issue #3225218 by TamakiFujino, kumikoono, yas: Align the comments at...

yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.