Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
- Check and align comments at
Drupal\k8s\Controller\ApiControllerInterface
- The following is a list of CamelCase resource names (the other one is NOT CamelCame):
ConfigMaps
CronJob
DaemonSet
LimitRange
ReplicaSet
ServiceAccount
StatefulSet
- See also the Glossary page: https://kubernetes.io/docs/reference/glossary/?all=true
- Format:
/** * Update all K8s <Resource Name or ResourceName>. * * @param string $cloud_context * Cloud context string. * * @return \Symfony\Component\HttpFoundation\RedirectResponse * A redirect response object that may be returned by the controller. */
- For example:
/** * Update all K8s LimitRanges. * * @param string $cloud_context * Cloud context string. * * @return \Symfony\Component\HttpFoundation\RedirectResponse * A redirect response object that may be returned by the controller. */
/** * Update all K8s Network Policies. * * @param string $cloud_context * Cloud context string. * * @return \Symfony\Component\HttpFoundation\RedirectResponse * A redirect response object that may be returned by the controller. */
Comment | File | Size | Author |
---|---|---|---|
#4 | cloud-2578.diff | 615 bytes | TamakiFujino |
Issue fork cloud-3225218
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3225218-align-the-comments changes, plain diff MR !367
Comments
Comment #3
kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commentedComment #4
TamakiFujino CreditAttribution: TamakiFujino commentedPlease review
Comment #6
TamakiFujino CreditAttribution: TamakiFujino commentedComment #7
TamakiFujino CreditAttribution: TamakiFujino commentedComment #8
kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented@tamaki The patch looks good to me. Thanks!
Comment #9
yas@tamakifujino
Thank you for supplying the patch. I posted a minor comment above. Please check it. Thanks!
Comment #10
yas@tamakifujino
Thank you for the update. I'll merge the patch to
4.x
and close this issue as Fixed.Comment #13
yas