Apparently a composer.json file is now required in order for MR workflow testing to work.

See #3190556: Illegal choice 0 in field_fivestar element for fivestar widget, where the tests on the MR fail because the votingapi dependency is not loaded at test time, despite being declared in fivestar.info.yml and despite being enabled in the functional tests.

CommentFileSizeAuthor
#2 3224344-2-composer.patch668 bytesTR
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TR created an issue. See original summary.

TR’s picture

TR CreditAttribution: TR commented
Status: Active » Needs review
FileSize
3224344-2-composer.patch668 bytes
TR’s picture

TR CreditAttribution: TR commented

OK, that didn't break anything. I'm going to commit #2 and see if it fixed #3190556: Illegal choice 0 in field_fivestar element for fivestar widget.

  • TR committed d3bdab3 on 8.x-1.x 
    Issue #3224344 by TR: composer.json is required for MR testing
TR’s picture

TR CreditAttribution: TR commented
Status: Needs review » Fixed

That fixed it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.