Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
For my own workflow (jumping between the UI and the Drush command drush upgrade_status:analyze machine_name
) I found it useful to have the machine_name of the module available in the UI.
Proposed resolution
On the form admin/reports/upgrade-status
I propose we add a column with the module machine_name
.
Screenshot:
https://www.drupal.org/files/issues/2021-07-09/2021-07-09-142424-upgrade...
See the attached patch.
Comment | File | Size | Author |
---|---|---|---|
#19 | 3222984-19.patch | 616 bytes | hmendes |
#19 | interdiff_13-19.txt | 1 KB | hmendes |
#13 | 3222984-13.patch | 989 bytes | hmendes |
#13 | 3222984_screenshot.png | 161.53 KB | hmendes |
#2 | 3222984-2.patch | 1.49 KB | michaellenahan |
Issue fork upgrade_status-3222984
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
michaellenahan CreditAttribution: michaellenahan at Hubert Burda Media commentedHere is the patch.
Comment #3
michaellenahan CreditAttribution: michaellenahan at Hubert Burda Media commentedComment #4
michaellenahan CreditAttribution: michaellenahan at Hubert Burda Media commentedComment #7
hotwebmatter CreditAttribution: hotwebmatter at Esteemed - Drupal Contractors commentedGreat idea. Patch is simple Form API code, clearly appropriate, and works well. Make it so.
P.S.: Here's the screenshot:
Comment #8
hotwebmatter CreditAttribution: hotwebmatter at Esteemed - Drupal Contractors commentedComment #9
Kristen PolThis would be helpful for me but I'd also *really* like a link to the project page. If you click on the project name, it gives you the upgrade status details. I'm wondering if this new column should be combined with a link off to the project page to handle this case as well. Thoughts?
Comment #10
Gábor HojtsyThere is an abudance of columns and you already need a sizable screen to fit it all :D So I am a bit wary to add more. If we can come up with creative ways to present this differently or some existing data differently so that it fits better that would be great.
Comment #11
Kristen PolTrue :) What about tacking it onto the end of the first column, e.g.
MEDIA ENTITY DOCUMENT (media_entity_document)
?Comment #12
michaellenahan CreditAttribution: michaellenahan at Hubert Burda Media commentedComment #13
hmendes CreditAttribution: hmendes at CI&T commentedHello, adding a patch with the suggestion from #11 and a screenshot.
Comment #14
hmendes CreditAttribution: hmendes at CI&T commentedI haven't updated the title and IS to wait to see if this approach is accepted first.
If you want i can change the MR as well.
Comment #15
Kristen PolThanks for updating the patch. A couple things:
Nitpick: How about combining these into one line? e.g.
Nitpick: To be consistent with other code, it would be good to change the double quotes to single quotes like shown here:
Comment #16
Kristen PolI think it looks good :)
Comment #17
Kristen PolActually, I see there is a
$extension->getName()
that could be used instead of getting the name yourself, so how about just using:or, alternatively, adding the
$extension->getName()
when$extension->info['name']
gets set instead.Comment #18
Kristen PolComment #19
hmendes CreditAttribution: hmendes at CI&T commentedChanging the patch to get the
$extension->getName()
instead of$extension->getPathname()
as suggested in #17.Looks cleaner now :)
Comment #20
Gábor HojtsyThanks! Re linking to the project page @kristen_pol, the drupal.org issues column already links to a filtered issue queue for the project. The project page itself should be one click from there. I know that is not a direct link but there is only so much space in this table :D
Comment #21
Gábor HojtsyComment #23
Gábor HojtsyFix race condition problem :D