Problem/Motivation

The default value is NULL, but assertTrue() expects a string.

Steps to reproduce

The only usage in core has an explicit value, so we didn't notice.

Proposed resolution

Change the default to ''. Also for the Not method.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3221966-5.patch1.26 KBanweshasinha
#2 3221966-2.patch1.79 KBguilhermevp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

guilhermevp’s picture

guilhermevp CreditAttribution: guilhermevp at CI&T commented
Status: Active » Needs review
FileSize
3221966-2.patch1.79 KB

Sending patch, please review.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/core/phpunit.xml.dist
@@ -1,5 +1,6 @@
 
+<!-- For how to customize PHPUnit configuration, see core/tests/README.md. -->
 <!-- TODO set checkForUnintentionallyCoveredCode="true" once https://www.drupal.org/node/2626832 is resolved. -->
 <!-- PHPUnit expects functional tests to be run with either a privileged user

looks like you accidently added this line in here, that shouldn't be in the patch.

anweshasinha’s picture

anweshasinha CreditAttribution: anweshasinha at Valuebound commented

I am working on it

anweshasinha’s picture

anweshasinha CreditAttribution: anweshasinha at Valuebound commented
FileSize
3221966-5.patch1.26 KB
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
guilhermevp’s picture

guilhermevp CreditAttribution: guilhermevp at CI&T commented
Status: Needs review » Reviewed & tested by the community

Sorry @Beredir, I was in a MR branch and forgot to checkout. Now, the patch seems fine! Moving to RTBC.

  • catch committed 7a1c996 on 9.3.x 
    Issue #3221966 by guilhermevp, anweshasinha, Berdir: PathAliasTestTrait...

  • catch committed 9193ea0 on 9.2.x 
    Issue #3221966 by guilhermevp, anweshasinha, Berdir: PathAliasTestTrait...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.