Problem/Motivation

The ForwardRevisionNodeValidationTest currently depends on workbench_moderation from contrib. It might be better to depend on content_moderation in core.

Remaining tasks

Review patch

CommentFileSizeAuthor
#3 interdiff-1-3.txt1.97 KBmstrelan
#3 entity_hierarchy-3220723-3-test-content-moderation.patch3.84 KBmstrelan
entity_hierarchy-test-content-moderation.patch2.89 KBmstrelan

Comments

mstrelan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented 
+++ b/tests/src/Functional/ForwardRevisionNodeValidationTest.php
@@ -76,9 +76,7 @@ class ForwardRevisionNodeValidationTest extends BrowserTestBase {
     $buttons = [
-      'Save and Publish',
-      'Save and Create New Draft',
-      'Save and Archive',
+      'Save',
       'Preview',
     ];
     foreach ($buttons as $button) {

we can ditch this rubbish workaround too now

+1 for this, thanks

mstrelan’s picture

mstrelan commented
StatusFileSize
new entity_hierarchy-3220723-3-test-content-moderation.patch3.84 KB
new interdiff-1-3.txt1.97 KB

Done, also standardised usage of SELF / STATIC and fixed the description in the class docblock.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

  • larowlan committed 58b6c60 on 3.x authored by mstrelan 
    Issue #3220723 by mstrelan: Consider testing with content_moderation...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

thanks, cutting 3.0.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.