Fix spelling for words used once, beginning with 'j' -> 'm', inclusive

+++ b/core/lib/Drupal/Component/Utility/Unicode.php
@@ -295,12 +295,12 @@ public static function ucwords($text) {
+   *   string "See my-very-long-url-example.com for more information" to a word-safe
    *   return length of 20, the only available word boundary within 20 characters
    *   is after the word "See", which wouldn't leave a very informative string. If

Dashes are wordsafe so this example is wrong now.

>>> \Drupal\Component\Utility\Unicode::truncate("See myverylongurlexample.com for more information", 20, TRUE);
=> "See"

>>> \Drupal\Component\Utility\Unicode::truncate("See my-very-long-url-example.com for more information", 20, TRUE);
=> "See my-very-long-url"

Needs reroll and #4 also needs addressing.

Hey, I made a new reroll based on #9. Moving back to NR.

Re-rolled patch against 9.4.x

Thank you @quietone, @murilohp and @karishmaamin.

Patches #12 and #13 are identical except #13 has an extra blank line in DbDumpCommand, which looks more correct to me.

Everything else looks good so #13 is RTBC if the bot agrees.

Thanks for your work on this issue!

I read over all the changes in this issue. (I did not check to ensure each item was used only once, nor to verify that other j-m words still in the dictionary were either valid or used at least twice.)

A few things to fix:

1. +++ b/core/lib/Drupal/Core/Command/DbDumpCommand.php
   @@ -8,6 +8,8 @@
   +// cspell:ignore mysqldump
   
   +++ b/core/misc/cspell/dictionary.txt
   @@ -736,14 +731,11 @@ localetranslatedirty
   -longblob
   ...
    longtext
   
   @@ -857,10 +840,7 @@ myclabs
   -mysqldump
   
   +++ b/core/modules/mysql/src/Driver/Database/mysql/Schema.php
   +++ b/core/modules/mysql/src/Driver/Database/mysql/Schema.php
   @@ -8,6 +8,8 @@
   
   @@ -8,6 +8,8 @@
   +// cspell:ignore longblob
   +
   

   I think it might be better to leave these in the dictionary. It seems strange to ignore them in only a single file since they are actually technical terms outside the context of those files. Especially for LONGBLOB -- I guess other terms like LONGTEXT must be used more than once, but we would end up with an ignore list of all the MySQL/Maria field types.

2. +++ b/core/lib/Drupal/Core/Utility/ThemeRegistry.php
   @@ -55,7 +55,7 @@ public function __construct($cid, CacheBackendInterface $cache, LockBackendInter
   -    // @todo: Implement lazyload.
   +    // @todo: Implement lazy load.
   

   As the object of a noun, this should probably be "lazy loading".

   "To lazy-load X" (hyphenated) would be a transitive verb. "Lazy load" as a noun would be a load that is lazy (the load itself is like a lazy person), not a load that is done lazily. ;)

3. +++ b/core/misc/cspell/dictionary.txt
   @@ -736,14 +731,11 @@ localetranslatedirty
    loreming
   -loremipsumloremipsum
   
   +++ b/core/modules/comment/tests/src/Functional/CommentInterfaceTest.php
   @@ -247,9 +247,9 @@ public function testAutoFilledSubject() {
   -    $body_text2 = 'LoremipsumloremipsumLoremingipsumLoremipsum';
   +    $body_text2 = 'LoremIpsumLoremIpsumLoremingIpsumLorempsum';
   ...
   -    $this->assertEquals('LoremipsumloremipsumLoreming…', $comment2->getSubject());
   +    $this->assertEquals('LoremIpsumLoremIpsumLoreming…', $comment2->getSubject());
   

   I think we can also get rid of "Loreming" here? Or, oh, I guess that out of scope because it's used twice. Never mind. Leaving my comment here in case another reviewer gets caught by that.

4. +++ b/core/modules/filter/tests/src/Kernel/FilterKernelTest.php
   @@ -761,7 +761,7 @@ public function testUrlFilter() {
   -HTML www.example21.com soup by person@example22.com can litererally http://www.example23.com contain *img*<img> anything. Just a www.example24.com with http://www.example25.com thrown in. www.example26.com from person@example27.com with extra http://www.example28.com.
   +  HTML www.example21.com soup by person@example22.com can literally http://www.example23.com contain *img*<img> anything. Just a www.example24.com with http://www.example25.com thrown in. www.example26.com from person@example27.com with extra http://www.example28.com.
   

   It looks like the indentation is wrong here. It was wrong before, but here it appears that we're changing it by one character too many in the other direction.

5. +++ b/core/modules/system/tests/src/Functional/Form/ElementsTableSelectTest.php
   @@ -241,7 +241,7 @@ private function formSubmitHelper($form, $edit) {
   -    // to allow the caller lowlevel access to the form.
   +    // to allow the caller low level access to the form.
   

   Here "low-level" should be hyphenated.

I think this is close once those points are addressed. Thanks!

All review points were addressed - back to RTBC.

Added reroll of patch #16 on Drupal 10.0.x.

Added interdiff of conflicts files.

It's green so the setting status to needs review.

And the reroll is good so back to RTBC.

+++ b/core/lib/Drupal/Core/Command/DbDumpCommand.php
@@ -8,6 +8,7 @@
 
+// cspell:ignore mysqldump
 /**

+++ b/core/modules/mysql/src/Driver/Database/mysql/Schema.php
@@ -8,6 +8,8 @@
 
+// cspell:ignore longblob
+

Just to clarify -- I think longblob, mysqldump, etc. should be left in the dictionary (not ignored inline) because they are terms it would be perfectly legitimate to use elsewhere in core. Thanks!

Made changes according to comment #22 :)

+++ b/core/modules/quickedit/tests/src/Functional/QuickEditEndPointAccessTest.php
@@ -56,6 +56,7 @@ public function testEndPointAccess() {
 
     $edit = [];
     $edit['form_id'] = 'quickedit_field_form';
+    // cspell:disable-next-line

+++ b/core/tests/Drupal/Tests/Component/Utility/UrlHelperTest.php
@@ -164,6 +164,7 @@ public function testValidRelative($url, $prefix) {
    */
   public function providerTestInvalidRelativeData() {
     $data = [
+      // cspell:disable-next-line

I think so we need disable-next-line in the dictionary .maybe use elsewhere in core.

I could not apply the patch in #23 neither for branch 10.0.x nor 9.5.x. Here's the output:

error: patch failed: core/misc/cspell/dictionary.txt:655
error: core/misc/cspell/dictionary.txt: patch does not apply

I'm novice, so I'm not sure if I just didn't set my local environment correctly. Keeping "Needs Review" for someone else check it out.

Despite that, it contemplates the changes suggested in #22: no longer ignoring inline // cspell:ignore mysqldump and // cspell:ignore longblob; and keeping longblob and mysqldump in the dictionary.

With that, the list of words beginning with j -> m, with the exception of longblob and mysqldump for the considerations in #15, was removed as proposed.

I'm not sure if I understood right the comment #25, letting it for someone else too.

#27 is correct, patch from #23 does not apply.

Added reroll of patch #23 on Drupal 10.0.x.

Hi, i'll be reviewing the last patch :)

the patch from #29 still has an error

error: patch failed: core/misc/cspell/dictionary.txt:761
error: core/misc/cspell/dictionary.txt: patch does not apply

I created another patch an is know working with everything. Maintaining in needs work and the tag since the error already occurred 2 times.

Addressed Drupal CS issues of patch #33 and patch #29.

Removed the needs reroll tag.

I reviewed the latest patch (both the drupal 9.5.x and 10.0.x versions), both apply without errors, address and resolve the issues in #33 and #29. As it passed all tests and presented no errors, I will be moving the issue to RTBC. Feel free to change the status of the issue if you believe there is still a pending discussion.

This is getting close, thanks! Just a couple points:

1. +++ b/core/lib/Drupal/Core/Utility/ThemeRegistry.php
   @@ -55,7 +55,7 @@ public function __construct($cid, CacheBackendInterface $cache, LockBackendInter
   +    // @todo: Implement lazy load.
   

   This should be hyphenated. I would actually say "Implement lazy-loading."

2. +++ b/core/modules/comment/tests/src/Functional/CommentInterfaceTest.php
   @@ -247,9 +247,10 @@ public function testAutoFilledSubject() {
   +    // cspell:ignore Lorempsum
   +    $body_text2 = 'LoremIpsumLoremIpsumLoremingIpsumLorempsum';
   

   Could we just use a long enough real word here to avoid having to add the cspell:ignore?

3. +++ b/core/modules/system/tests/src/Functional/Form/ElementsTableSelectTest.php
   @@ -241,7 +241,7 @@ private function formSubmitHelper($form, $edit) {
   +    // to allow the caller low level access to the form.
   

   "low-level" should be hyphenated.

4. +++ b/core/modules/views/tests/src/Functional/Handler/HandlerAllTest.php
   @@ -70,7 +70,7 @@ public function testHandlers() {
   +        // Table is a reserved key for the meta information.
   

   "meta-information" should be hyphenated.

This issue is tagged for first time contributors at DrupalCon Prague 2022.

@xjm,
Made changes as per comment #36.
Needs review.

Hi Ratan Priya, whilst everyones appreciates contributions and moving these issues forwards, in comment #37 Chris Darke had requested that this issue be held for Prague 2022 DrupalCon first time contributors.
I would encourage the reading of the issue comment thread prior to updating to make sure this is avoided as a lot of time is put into doing issue triage to identify these for the events.

I would try to work with this issue at DrupalCon Prague.

@petu how far did you get with this issue. I'm novice and would like to join and work together on this issue

Hi @hayburner,

no valuable progress so far.

Latest patches do not apply.

Rerolled patch #39 in 9.5.x .

I have uploaded the patch against 9.5.x - Please review

#36 is in the latest patch i hope with cspell error/ignore

Tested Patch #48 against 9.5.x and its applied successfully and dictionary.txt file changed after applying patch.

We need a 10.x version of the patch too. Unfortunately the 9.5.x patch does not apply there.

Created patch for 10.0.x by considering the comment of #51

Updated patch as per to PHPCS

Tested the patch from #53 for version 10.0.x .Patch is not applying and showing below error

error: patch failed: core/misc/cspell/dictionary.txt:656
error: core/misc/cspell/dictionary.txt: patch does not apply

Thanks @Roshni_Kodiganti

Looks like patch #53 is getting applied on Drupal 10.0.x.
please try to take a pull and then apply the patch.

Thanks.

Tested the patch from #53 for version 10.0.x .and its applied successfully.
dictionary.txt file changed and all above mentioned words are removed from dictionary.txt after applying patch.

We seem to have lost the changes suggested in #36. Some more notes:

1. +++ b/core/lib/Drupal/Component/Utility/Unicode.php
   @@ -2,6 +2,7 @@
   +// cspell:ignore myverylongurl myverylongurlexample
   

   Here we could use MyVeryLongURL and MyVeryLongURLExample in the docs instead of ignoring the words?

2. +++ b/core/modules/filter/tests/src/Kernel/FilterKernelTest.php
   @@ -737,7 +737,7 @@ public function testUrlFilter() {
   -      HTML www.example21.com soup by person@example22.com can litererally http://www.example23.com contain *img*<img> anything. Just a www.example24.com with http://www.example25.com thrown in. www.example26.com from person@example27.com with extra http://www.example28.com.
   +        HTML www.example21.com soup by person@example22.com can literally http://www.example23.com contain *img*<img> anything. Just a www.example24.com with http://www.example25.com thrown in. www.example26.com from person@example27.com with extra http://www.example28.com.
   

   The indentation has been changed here, it is now misaligned compared to the other text.

@Roshni_Kodiganti Thank you for looking into this issue.

Posting screenshots of your codebase does not advance the issue, since the automated testing infrastructure tells us whether the change set still applies correctly.

See the issue credit guidelines for more information.

had to reroll from #53.

From #36:
1. done
2. changed to Pneumonoultramicroscopicsilicovolcanoconiosis. that took 3 works related to lorem ipsum form the dictionary.
But had to add Pneumonoultramicroscopicsili to a cspell ignore on the test because it does test the work if is cut beyond 28 characters.
3. done
4.done

from #60:
1. done
2. done

Try TO Fix The Failed #62 Patch.

Cleaning up credits for bad rerolls/empty commits as it's expected to check your patches before uploading.

Patch #62 seemed to address the points and at the time the only failure was a random one. Still need to double check that the points are addressed.

Hiding patches #64 (no interdiff and patch before applied fine) and #67 (reverted back to patch 52 so would miss any potential fixes in 62).

=====

Just FYI to help get the message out there.

Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.

Example
error: patch failed: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module:77
error: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module: patch does not apply

To receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
See the issue credit guidelines for more information.

Addressed the fixes in comment #62 in my patch.

CC Failure.

BUT #67 skipped all the points there were attempted in #62.

So this appears to be carrying forward the wrong patch.

Think #62 should be the starting point.

Addressed all issues including #62.

Checking to see if "…" character got fixed in my last patch. Includes suggestions from #62.

Not sure #62 was the starting point. The interdiffs say it was 67. also the file sizes slightly went up what was the additional file needed that wasn't in #62?

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Fix The Failed Patch #76.
also, Add The Interdiff FOr 76-78.

Reading the patches, I did my best to unite from #62, #76 and #78. intediffs for all 3 of them.

I reverted the change that removed 'crc32' because its out of scope.

edit:
patch #62 and #76 does not apply in version 11.0.x and patch #79 does not apply in version 10.0.x.

what version should I focus on?

Cleaning up patches.

I think what you have in #79 is good. The words from the issue summary have been removed and aren't throwing errors.

Code has to be merged into 11.x first and backported later.

#79 doesn't apply. As #80 says let's concentrate on an 11.x patch first and we will worry about backporting after that if necessary.

Reroll looks good.

Thanks everyone - these spelling issues are taking longer than I ever imagined but we are finally getting some of them completed.

Committed 1bb050c and pushed to 11.x. Thanks!

Also backported to 10.1.x as the cherry-pick applied cleanly.

Unfortunately it looks like this patch fixed some spellings without updating the dictionary, for example: litererally - see #3386602: Remove incorrect spellings from the dictionary that are no longer in the codebase