Problem/Motivation

Fix errors while launching an EC2 instance from AWS Cloud Launch Template

CommentFileSizeAuthor
#30 hotfix-3217980-30.patch1.05 KByas
#22 hotfix-3217980-22.patch1.4 KByas
#3 3217980-3.patch1.64 KBxiaohua guan

Issue fork cloud-3217980

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !242

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
StatusFileSize
new 3217980-3.patch1.64 KB

@yas

Please review the code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for fixing the issue. I tested the patch and it fixes the issue and working fine. I posted my comments. Could you please review my suggestions for even further refactoring?

Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your suggestions. I agreed with them and also applied them. Please take a look again.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for applying the suggestions.

@baldwinlouie

What do you think?

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Needs work

@@xiaohua-guan an @yas, Thank you for the patch. I have one comment.

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@baldwinlouie

Thanks for your comment. I've fixed it. Could you confirm it? Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I think it resolved all our comments. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 98e1401 on 3.x authored by Xiaohua Guan 
    Issue #3217980 by Xiaohua Guan, yas, baldwinlouie: Fix errors while...

yas closed merge request !242

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas reopened merge request !242

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

Fix syntax errors:

The website encountered an unexpected error. Please try again later.

ParseError: Unclosed ‘{’ on line 173 does not match ‘)’ in Composer\Autoload\includeFile() (line 184 of modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php).
Composer\Autoload\includeFile() (Line: 346)
Composer\Autoload\ClassLoader->loadClass() (Line: 314)
Drupal\Core\Batch\BatchBuilder->addOperation() (Line: 1374)
Drupal\aws_cloud\Service\Ec2\Ec2Service->updateInstanceEntities() (Line: 1400)
Drupal\aws_cloud\Service\Ec2\Ec2Service->updateInstances() (Line: 726)
aws_cloud_update_ec2_resources() (Line: 143)
Drupal\aws_cloud\Controller\Ec2\ApiController->updateAll()
call_user_func_array() (Line: 123)

...

  • yas committed 61098b7 on 3217980-fix-errors-while authored by Xiaohua Guan 
    Issue #3217980 by Xiaohua Guan, yas: Fix errors while launching an EC2...
  • Xiaohua Guan authored 6beb431 on 3217980-fix-errors-while
    Issue #3217980 by Xiaohua Guan, yas, baldwinlouie: Hotfix - Fix errors...
  • yas committed d5bebd6 on 3217980-fix-errors-while authored by Xiaohua Guan
    Issue #3217980 by Xiaohua Guan, yas: Fix errors while launching an EC2...

yas closed merge request !242

yas reopened merge request !242

yas opened merge request !244

yas opened merge request !245

yas closed merge request !244

yas closed merge request !242

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new hotfix-3217980-22.patch1.4 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@all

All tests have been passed successfully, so I'll merge the patch to 3.x and close this issue as Fixed.

yas credited kumikoono.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

  • yas committed 74079f1 on 3.x 
    Issue #3217980 by yas, baldwinlouie: Hotfix - Fix errors while launching...

yas closed merge request !245

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

Re-opening this issue to fix an Internal Server Error: Undefined constant "Drupal\aws_cloud\Service\Ec2\instance" while creating AWS Cloud service provider

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new hotfix-3217980-30.patch1.05 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

All tests have been passed successfully, so I'll merge the patch to 3.x and 4.x, and close this issue as Fixed.

  • yas committed 6b56ac6 on 3.x 
    Issue #3217980 by yas: Hotfix - Fix errors while launching an EC2...

  • yas committed 0d8ed0f on 4.x 
    Issue #3217980 by yas: Hotfix - Fix errors while launching an EC2...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.