Problem/Motivation

assertNotRegExp() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertDoesNotMatchRegularExpression() instead.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 reroll_diff_5-9.txt3.3 KBSpokje
#9 3217711-9.patch5.42 KBSpokje
#5 3217711-5.patch5.54 KBsudiptadas19
#3 3217711-2.patch4.01 KBguilhermevp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Issue tags: +Novice, +PHPUnit 10
Parent issue: #3217709: Replace usages of assertRegExp(), that is deprecated » #3217904: [meta] Support PHPUnit 10 in Drupal 11
guilhermevp’s picture

guilhermevp CreditAttribution: guilhermevp at CI&T commented
Status: Active » Needs review
FileSize
3217711-2.patch4.01 KB

Sending patch!

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Needs work

Thank you.

We also need to remove from Drupal\Tests\Listeners\DeprecationListenerTrait::getSkippedDeprecations the corresponding deprecation silencer, so that if any instance remains, or other patches try to introduce back the old method, we have the testing framework informing us about that.

See #3174200: Use PHPUnit-bridge polyfills for forward compatibility layer for an example.

sudiptadas19’s picture

sudiptadas19 CreditAttribution: sudiptadas19 at QED42 for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3217711-5.patch5.54 KB

@mondrake added mention changes. Please review it.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community

RTBC. The PHP 7.3 test is green, indicating tests run OK on PHPUnit8. Deprecation silencer removed and all conversions done.

Even if this is a small patch, please add an interdiff when adding patches after the first one, so to facilitate reviewing. Thanks!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs re-roll

Needs a re-roll.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Assigned: Unassigned » Spokje

Re-rolling

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
FileSize
3217711-9.patch5.42 KB
reroll_diff_5-9.txt3.3 KB
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Assigned: Spokje » Unassigned
Status: Needs work » Needs review
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC per #6

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Issue tags: -Needs re-roll
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented

tips hat @longwave

  • catch committed 5098106 on 9.3.x 
    Issue #3217711 by Spokje, sudiptadas19, guilhermevp, mondrake: Replace...

  • catch committed 62ef2b4 on 9.2.x 
    Issue #3217711 by Spokje, sudiptadas19, guilhermevp, mondrake: Replace...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x, and then to 9.2.x without the deprecation suppression removal.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented

Does it make sense to keep the deprecation suppression in 9.2? It's a PHPUnit deprecation, not Drupal's where the minor matters.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

@mondrake the issue is that modules that were passing tests with rc1 could start failing tests with 9.2.0 (if they have deprecation fails switched on). We never unsuppress deprecation warnings in patch releases, and rcs fall under the same approach.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented

#18 ah ok got it, thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.