Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Olivero: Message icon has border radius in firefox browser.
This is fixed in chrome and other browsers.
Comment | File | Size | Author |
---|---|---|---|
#13 | After-patch-icon.png | 15.37 KB | radheymkumar |
#13 | before-patch-icon.png | 13.65 KB | radheymkumar |
#6 | After-patch-icon.png | 15.37 KB | Madhu kumar |
#6 | before-patch-icon.png | 13.65 KB | Madhu kumar |
#4 | After patch sc.png | 29.77 KB | manojithape |
Comments
Comment #2
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commentedAttached patch for the same. Removed border-radius: 50%; which causes the issue.
Comment #3
mitthukumawat CreditAttribution: mitthukumawat as a volunteer and at Zyxware Technologies for Drupal Association commented@Gauravmahlawat I have tested this patch manually in Olivero theme. The patch applied cleanly and fixed the border radius issue on messages close icon. Thanks for the patch
Adding before and after patch screenshots. RTBC+1
Comment #4
manojithape CreditAttribution: manojithape at QED42 for Drupal India Association commentedVerified and tested patch#2 on the drupal 9.3.x-dev version and Olivero 9.3.0-dev version. Patch applied successfully and looks good to me.
Testing Steps:
Testing Results:
After applying the patch Message close icon displayed in a square shape in the firefox browser.
Please refer attached Before patch sc and After patch sc images for reference.
Moving this ticket to RTBC.
Comment #5
manojithape CreditAttribution: manojithape at QED42 for Drupal India Association commentedMoved to RTBC.
Comment #6
Madhu kumar CreditAttribution: Madhu kumar as a volunteer and at Zyxware Technologies commentedApplied Patch #2 successfully and working as expected , provided screenshot for the reference .
Comment #8
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commentedunrelated failure.
Comment #11
lauriii@Madhu kumar Thank you for reviewing the issue! I have removed credit from you on this issue because the screenshots doesn't show the problem. Also, two other reviewers have already submitted screenshots on the issue, meaning that posting more screenshots isn't helpful.
Committed 0daba4e and pushed to 9.3.x and 9.2.x. Thanks!
Comment #12
tstoecklerAs far as I can tell the wrong patch was committed here. At least https://git.drupalcode.org/project/drupal/commit/0daba4e doesn't match https://www.drupal.org/files/issues/2021-05-15/3214140-2.patch
Sorry for the noise in case I'm missing something and this is in fact correct.
Comment #13
radheymkumar CreditAttribution: radheymkumar commentedApplied patch successfully. Attached screenshot
Thanks
Comment #14
tstoecklerOK, re-opening then to increase visibility. Not sure if this has been committed/pushed in the meantime, but I don't think so.
Comment #19
lauriiiThank you @tstoeckler! Reverted and committed again.