Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gauravmahlawat created an issue. See original summary.

Gauravvvv’s picture

Status: Active » Needs review
FileSize
850 bytes

Attached patch for the same. Removed border-radius: 50%; which causes the issue.

mitthukumawat’s picture

FileSize
15.32 KB
13.41 KB

@Gauravmahlawat I have tested this patch manually in Olivero theme. The patch applied cleanly and fixed the border radius issue on messages close icon. Thanks for the patch
Adding before and after patch screenshots. RTBC+1

manojithape’s picture

FileSize
33.09 KB
29.77 KB

Verified and tested patch#2 on the drupal 9.3.x-dev version and Olivero 9.3.0-dev version. Patch applied successfully and looks good to me.

Testing Steps:

  1. Install drupal 9.3.x-dev version.
  2. Go to Appearance -> Set Olivero theme as admin and default theme
  3. Open the drupal site in firefox browser and perform any action.
  4. Observe the Message close icon displayed in a circular shape in the firefox browser.
  5. Now apply patch and again perform any action and verify that the Message close icon displayed in a square shape in firefox browser.

Testing Results:

After applying the patch Message close icon displayed in a square shape in the firefox browser.
Please refer attached Before patch sc and After patch sc images for reference.

Moving this ticket to RTBC.

manojithape’s picture

Status: Needs review » Reviewed & tested by the community

Moved to RTBC.

Madhu kumar’s picture

FileSize
13.65 KB
15.37 KB

Applied Patch #2 successfully and working as expected , provided screenshot for the reference .

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3214140-2.patch, failed testing. View results

Gauravvvv’s picture

Status: Needs work » Reviewed & tested by the community

unrelated failure.

  • lauriii committed 0daba4e on 9.3.x
    Issue #3214140 by Gauravmahlawat, manojithape, mitthukumawat: Olivero:...

  • lauriii committed a8ac5ce on 9.2.x
    Issue #3214140 by Gauravmahlawat, manojithape, mitthukumawat: Olivero:...
lauriii’s picture

Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

@Madhu kumar Thank you for reviewing the issue! I have removed credit from you on this issue because the screenshots doesn't show the problem. Also, two other reviewers have already submitted screenshots on the issue, meaning that posting more screenshots isn't helpful.

Committed 0daba4e and pushed to 9.3.x and 9.2.x. Thanks!

tstoeckler’s picture

As far as I can tell the wrong patch was committed here. At least https://git.drupalcode.org/project/drupal/commit/0daba4e doesn't match https://www.drupal.org/files/issues/2021-05-15/3214140-2.patch

Sorry for the noise in case I'm missing something and this is in fact correct.

radheymkumar’s picture

FileSize
13.65 KB
15.37 KB

Applied patch successfully. Attached screenshot
Thanks

tstoeckler’s picture

Status: Fixed » Reviewed & tested by the community

OK, re-opening then to increase visibility. Not sure if this has been committed/pushed in the meantime, but I don't think so.

  • lauriii committed 5ffcad5 on 9.2.x
    Revert "Issue #3214140 by Gauravmahlawat, manojithape, mitthukumawat:...

  • lauriii committed 4c0fc0e on 9.3.x
    Revert "Issue #3214140 by Gauravmahlawat, manojithape, mitthukumawat:...

  • lauriii committed b1c2f22 on 9.3.x
    Issue #3214140 by Gauravmahlawat, manojithape, mitthukumawat, tstoeckler...

  • lauriii committed 8ead88c on 9.2.x
    Issue #3214140 by Gauravmahlawat, manojithape, mitthukumawat, tstoeckler...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Thank you @tstoeckler! Reverted and committed again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.