Problem/Motivation
Claro: Label and input field in the quick-edit toolbar does not have a space between them which makes them odd and the focus of the input field overlaps with the label.
Steps to reproduce
1. Go to any node.
2. Quick edit the node, the content type of the specific node page must contain an image field or media field.
3. Hover the mouse on the image.
4. You will see the quick-edit toolbar with the label name alternative text and input field.
5. There is no space between the label and the input field, the focus of the input field overlaps the label.
Comment | File | Size | Author |
---|---|---|---|
#17 | After--patch--pic--3214125.png | 49.78 KB | vikashsoni |
#17 | Before--patch--pic--3214125.png | 50.23 KB | vikashsoni |
#13 | After Patch 3214125.png | 985.4 KB | chetanbharambe |
#13 | Before Patch 3214125.png | 937.31 KB | chetanbharambe |
#11 | interdiff_2-10.txt | 718 bytes | IndrajithKB |
Issue fork drupal-3214125
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
Sakthivel M CreditAttribution: Sakthivel M at QED42 for Drupal India Association commented#2 Please review the patch
Comment #3
mitthukumawat CreditAttribution: mitthukumawat as a volunteer and at Zyxware Technologies for Drupal Association commentedI have tested the patch #2 manually and it fixed the issue of focus in quickedit images in Claro theme.
Adding screenshots for reference. RTBC+1
Comment #4
Madhu kumar CreditAttribution: Madhu kumar as a volunteer and at Zyxware Technologies commentedApplied patch #2 Successfully and working as expected .Screenshot for the reference.
Comment #5
manojithape CreditAttribution: manojithape at QED42 for Drupal India Association commentedVerified and tested patch#2 on the drupal 9.3.x-dev version and Claro 9.3.0-dev version. Patch applied successfully and looks good to me.
Testing Steps:
Testing Results:
After applying patch space displayed between the label and the input field and issue of focus in quick-edit images in Claro theme fixed.
Please refer attached Before patch sc and After patch sc images for reference.
Moving this ticket to RTBC.
Comment #6
manojithape CreditAttribution: manojithape at QED42 for Drupal India Association commentedComment #7
radheymkumar CreditAttribution: radheymkumar commentedSuccessfully applied patch and attach screenshot
Thanks
Comment #11
IndrajithKB CreditAttribution: IndrajithKB at Srijan | A Material+ Company for Drupal India Association commentedHere i have updated the MR according with the design, please review.
Design link: https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system...
Comment #12
IndrajithKB CreditAttribution: IndrajithKB at Srijan | A Material+ Company for Drupal India Association commentedMoving back to NR.
Comment #13
chetanbharambe CreditAttribution: chetanbharambe at QED42 for Drupal India Association commentedVerified and tested merge request !1176 (https://git.drupalcode.org/project/drupal/-/merge_requests/1176.patch)
Patch applied successfully and looks good to me.
Testing Steps:
# Goto: Appearance -> Apply Claro theme
# Goto Extend: Install Quick edit module
# Create the node which has an image field mentioning alternative text
# Quick edit the node, the content type of the specific node page must contain an image field or media field.
# Hover the mouse on the image.
# You will see the quick-edit toolbar with the label name alternative text and input field.
Expected Results:
# There should be some space between the label and the input field, the focus of the input field overlaps the label.
Actual Results:
# There is no space between the label and the input field, the focus of the input field overlaps the label.
Please refer attached screenshots for the same.
Looks good to me.
Can be a move to RTBC.
Comment #14
lauriiiPosted feedback on the MR
Comment #15
bnjmnmThere are significantly more before/after screenshots than necessary here. Removing credit for any comments that add already-provided screenshots without additional content. Definitely removing credit for #7, which just re-uploaded the screenshots from #5 with new filenames.
Comment #17
vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commentedApplied patch #2 in drupal-9.3.x-dev working fine.
for ref sharing screenshot
Comment #18
bnjmnmRemoving credit for #17. Just 2 comments up in #15 I mentioned there were already more screenshots than needed and removed credit for several comments that simply added more of what we already have.
Also in #17:
. Patch #2 is outdated. The work has moved to a merge request and has changed since #2. Be sure to review the most recent changes.
Comment #22
pameeela CreditAttribution: pameeela at Technocrat commentedDiscussed with larowlan in Slack and we agree this should be fixed in the contrib module, since it Quick Edit is no longer in core.