Split off from #3153234: [Meta] Olivero JavaScript should be selecting [data-drupal-selector] attributes where possible

We need to be using [data-drupal-selector] attribute selectors in scripts.es6.js

Testing instructions

  1. Load the homepage at wide widths.
  2. Scroll down, verify fixed header functionality hasn't changed.
  3. Verify that the social bar becomes fixed the page is scrolled down.
  4. Load page at narrow widths
  5. Verify that the mobile menu functionality works the same.
CommentFileSizeAuthor
#4 Screen Recording 2021-05-09 at 08.10.49.mov15.26 MBGauravvvv
#2 3212998.patch8.29 KBmherchel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Issue summary: View changes
FileSize
3212998.patch8.29 KB

Patch attached.

Tugboat URL: https://3212998-normalize-scripts-js-ksosl0r8qtfcxwnlwys2zbl4grjfseij.tu...

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Status: Active » Needs review
Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Recording 2021-05-09 at 08.10.49.mov15.26 MB

I have verified all the testing instruction steps on live-preview. Adding screen recording for reference.

Marking as RTBC

  • lauriii committed 08a9dcb on 9.3.x 
    Issue #3212998 by mherchel, Gauravmahlawat: Olivero: Normalize...

  • lauriii committed 31deaf5 on 9.2.x 
    Issue #3212998 by mherchel, Gauravmahlawat: Olivero: Normalize...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 08a9dcb and pushed to 9.3.x and 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.