Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
#3143096: [DX]: throw an exception if #lazy_builder callback does not return a (renderable) array introduced some nice, debuggable error handling when lazy builder callbacks fail to return renderable arrays. However, it doesn't cover all cases -- lazy builders can be instance methods of objects (e.g., [$this, 'lazyBuilder']), and the code will choke on that and produce a fatal error, rather than the helpful exception we'd like it to.
Steps to reproduce
Not really needed; these are API-level edge(-ish) cases.
Proposed resolution
Renderer::renderRoot() should handle object callables when building the exception.
Remaining tasks
Write a failing test, then fix the problem.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
None needed.
Issue fork drupal-3212049
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
phenaproximaComment #4
phenaproximaComment #5
alexpottI've reviewed this code and it's made me realise the @phenaproxima was correct I should revert #3143096: [DX]: throw an exception if #lazy_builder callback does not return a (renderable) array - I think we should use an assert and move the callable to string stuff to \Drupal\Component\Utility\Variable.