Across the Olivero theme we're using outline-offset: 2px; but only the close button on the messages container is using outline-offset: 1px;. This is inconsistent.

This can be seen on the live preview. Adding screenshot for reference.
https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/search/node?...

CommentFileSizeAuthor
#10 Before Patch 3211613.png415.66 KBchetanbharambe
#10 After Patch 3211613.png414.64 KBchetanbharambe
#8 Screenshot from 2021-05-26 16-33-25.png36.28 KBMadhu kumar
#7 3211613.7.patch837 bytesSakthivel M
#3 3211613-3.patch837 bytesGauravvvv
Screenshot 2021-04-30 at 15.24.57.png84.27 KBGauravvvv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gauravmahlawat created an issue. See original summary.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
Issue summary: View changes
Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
FileSize
3211613-3.patch837 bytes

I have updated from outline-offset: 1px; to outline-offset: 2px;

Attached patch for the same.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
Status: Active » Needs review
mitthukumawat’s picture

mitthukumawat CreditAttribution: mitthukumawat as a volunteer and at Zyxware Technologies for Drupal Association commented

Patch applied cleanly for me and the outline-offset is 2px for search error cancel button on focus. By the way I did not see much difference in the button UI before and after patch. I could see the changes in CSS files.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Sakthivel M’s picture

Sakthivel M CreditAttribution: Sakthivel M at QED42 for Drupal India Association commented
FileSize
3211613.7.patch837 bytes

Just Re-roll the patch 9.3.x

Madhu kumar’s picture

Madhu kumar CreditAttribution: Madhu kumar as a volunteer and at Zyxware Technologies commented
FileSize
Screenshot from 2021-05-26 16-33-25.png36.28 KB

Patch #7 applied cleanly and changing the outline-offset: 2px; in the messages.pcss.css component

chetanbharambe’s picture

chetanbharambe CreditAttribution: chetanbharambe at QED42 for Drupal India Association commented
Assigned: Unassigned » chetanbharambe
chetanbharambe’s picture

chetanbharambe CreditAttribution: chetanbharambe at QED42 for Drupal India Association commented
Assigned: chetanbharambe » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
After Patch 3211613.png414.64 KB
Before Patch 3211613.png415.66 KB

Verified and tested patch #7.
Patch applied successfully and looks good to me.

Testing Steps:
# Apply Oliver theme from Appearance
# Goto: search/node?keys=
# Inspect element and check that outline-offset: 1px; in the messages.pcss.css component

Expected Results:
# User should see outline-offset: 2px; in the messages.pcss.css component

Actual Results:
# Inspect element and check that outline-offset: 1px; in the messages.pcss.css component

Looks good to me.
Can be a move to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 3211613.7.patch, failed testing. View results

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
Status: Needs work » Reviewed & tested by the community

Unrelated failure

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Title: Olivero: un-uniform offset on search cancel button on search page » Olivero: Inconsistent offset on close button within messages
Issue summary: View changes

RTBC +1. Thanks!

  • lauriii committed 88968d7 on 9.3.x 
    Issue #3211613 by Gauravmahlawat, Sakthivel M, chetanbharambe: Olivero:...

  • lauriii committed 90a61c2 on 9.2.x 
    Issue #3211613 by Gauravmahlawat, Sakthivel M, chetanbharambe: Olivero:...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 88968d7 and pushed to 9.3.x. Also cherry-picked to 9.2.x Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.