Problem/Motivation

We have a number of words in the dictionary that cspell thinks are incorrect:

nblocks
ncck
ncontent
nmenu
npoll
nprofile
nstrings
nsync
ntaxonomy

Each of these is prefixed with "i18n" as they are internationalization related.

Steps to reproduce

Proposed resolution

Ignore \Wi18n in cspell and remove these from the dictionary.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3210694.patch940 byteslongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3210694.patch940 bytes
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

Not sure about this, these words are already in #3209249: Fix spelling for 29 migrate translation related words.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

To me this is simpler and cleaner than adding cspell:ignore a number of times for all these words that aren't really words anyway, they are misinterpretations of the "i18n" prefix.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Status: Needs review » Reviewed & tested by the community

I'm on #TeamLongwave on this one, main reason:

simpler and cleaner than adding cspell:ignore a number of times for all these words that aren't really words anyway, they are misinterpretations of the "i18n" prefix.

(Possible issue: When this former boy band resurrects for a commercially based reunion tour and their name is used in the Drupal Code... 😇)

Tests are green: RTBC for me.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

I see your point. I think this now needs an @todo and a followup to remove the regex when #3010983: Deprecate Drupal 6 and Drupal 7 migrations and move to contrib is done.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented

@quietone Followup: Yes
@todo: Tricky when the only file changed is a JSON file, which doesn't really do comments as far as I know.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Yeah, you cannot add comments to JSON files. I don't think it will really hurt anything by leaving it in there longer than necessary though.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented

I don't think it will really hurt anything by leaving it in there longer than necessary though.

Agreed, does that also means a follow-up isn't really necessary, or should we create one anyway?

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

I updated the IS in #3010983: Deprecate Drupal 6 and Drupal 7 migrations and move to contrib to include looking at cspell. So, all good here.
Thanks @longwave and @Spokje.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 2dd115febb to 9.2.x and 5ea1aa188a to 9.1.x. Thanks!

Backported to 9.1.x as this is testing infra change and keeps things aligned.

  • alexpott committed 2dd115f on 9.2.x 
    Issue #3210694 by longwave, quietone, Spokje: Ignore i18n-prefixed words...

  • alexpott committed 5ea1aa1 on 9.1.x 
    Issue #3210694 by longwave, quietone, Spokje: Ignore i18n-prefixed words...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.