Problem/Motivation

Followup to #1624278: cleanup of docblock to UI text in update_get_update_list() is weak.

Convert \Drupal\Tests\system\Functional\UpdateSystem\UpdateDescriptionTest to a Unit test.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3210502-3.patch3.71 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Related issues: +#1624278: cleanup of docblock to UI text in update_get_update_list() is weak
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Title: Convert UpdateDescriptionTest to a Unit test. » Convert UpdateDescriptionTest to a kernel test
Status: Active » Needs review
FileSize
3210502-3.patch3.71 KB

Converting this to a unit test required mocking a number of services, it seems easier to make this a kernel test and then we can allow modules to be installed.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Status: Needs review » Reviewed & tested by the community

- New test is green.
- New test basically tests for the same thing, but without the overhead of a BrowserTestBase
- All things done in the original test besides the 2 assertions on return messages from Update Manager weren't asserted, and are all covered in the remaining BrowserTestBase tests for Update Manager.

Converting this to a unit test required mocking a number of services, it seems easier to make this a kernel test and then we can allow modules to be installed.

- Makes sense.

RTBC for me.

  • catch committed edf8109 on 9.2.x 
    Issue #3210502 by longwave, quietone, Spokje: Convert...

  • catch committed 8aca3cd on 9.1.x 
    Issue #3210502 by longwave, quietone, Spokje: Convert...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Nice find!

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Parent issue: » #3041700: [META] Convert some tests into Kernel or Unit tests

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.