Context sensitive translation issue in system module [#320793]

Comment	File	Size	Author
#3	D7_core_system_context_sensitive_bug_2008101401.patch	2.41 KB	hass

#3	D6_core_system_context_sensitive_bug_2008101401.patch	2.3 KB	hass

	D7_core_system_context_sensitive_bug_2008101301.patch	2.46 KB	hass

	D6_core_system_context_sensitive_bug_2008101301.patch	2.35 KB	hass

Comment #1

Damien Tournoud CreditAttribution: Damien Tournoud commented 13 October 2008 at 21:55

Status:

Needs review

» Reviewed & tested by the community

Looks great, thanks for all of us non english-speaking :)

Log in or register to post comments

Comment #2

Dries CreditAttribution: Dries commented 14 October 2008 at 20:28

Status:

Reviewed & tested by the community

» Needs work

Elsewhere in Drupal, we tend to use @module instead of @module_name. Can we reroll with such a change?

Log in or register to post comments

Comment #3

hass CreditAttribution: hass commented 14 October 2008 at 21:06

Status:

Needs work

» Needs review

File	Size
D6_core_system_context_sensitive_bug_2008101401.patch	2.3 KB

D7_core_system_context_sensitive_bug_2008101401.patch	2.41 KB

re-roled with @module.

Log in or register to post comments

Comment #4

drewish CreditAttribution: drewish commented 16 October 2008 at 16:18

looks like a simple enough change to me.

Log in or register to post comments

Comment #5

Damien Tournoud CreditAttribution: Damien Tournoud commented 16 October 2008 at 16:21

Status:

Needs review

» Reviewed & tested by the community

Thanks hass.

Log in or register to post comments

Comment #6

Dries CreditAttribution: Dries commented 16 October 2008 at 20:23

Status:

Reviewed & tested by the community

» Fixed

Committed to CVS HEAD and DRUPAL-6. Thanks!

Log in or register to post comments

Comment #7

hass CreditAttribution: hass commented 16 October 2008 at 21:24

THX :-)

Log in or register to post comments

Comment #8

Pasqualle

🇭🇺 Budapest

CreditAttribution: Pasqualle commented 19 October 2008 at 18:04

Status:

Fixed

» Postponed (maintainer needs more info)

I understand that this is better than it was.
I just would like to know, why do we accept patches like this for D6? What is the policy on D6 string changes?

There could be many similar small fixes for D6, but the D6 is translated, and I think this patch just made more work for D6 translators and D6 users..