Problem/Motivation

  • Refactor titles and descriptions of the permissions
CommentFileSizeAuthor
#7 3206856-7.patch72.44 KByas
#4 3206856-4.patch50.61 KByas

Issue fork cloud-3206856

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas opened merge request !198

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Active » Needs work

@yas, Thank you for the refactoring. I have two comments above.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Needs review
FileSize
3206856-4.patch50.61 KB

@baldwinlouie

I fixed the typo and description. I really appreciate you for your review!

Status: Needs review » Needs work

The last submitted patch, 4: 3206856-4.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Needs review

@baldwinlouie

I removed unpublished permissions and refactor the test code, too.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3206856-7.patch72.44 KB
baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented

@yas, thanks for the updated patch. It looks good to me now.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for your review. I'll merge the patch to 3.x and close this issue as Fixed. Thanks

  • yas committed 32c47f0 on 3.x 
    Issue #3206856 by yas, baldwinlouie: Refactor titles and descriptions of...

yas closed merge request !198

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.