Problem/Motivation

    // @todo When not using the Symfony Session object, the list of bags in the
    //   NativeSessionStorage will remain uninitialized. This will lead to
    //   errors in NativeSessionHandler::loadSession. Remove this after
    //   https://www.drupal.org/node/2229145, when we will be using the Symfony
    //   session object (which registers an attribute bag with the
    //   manager upon instantiation).

#2229145: Register symfony session components in the DIC and inject the session service into the request object is long closed but the @todo remains.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3206358-2.patch913 byteslongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
FileSize
913 bytes

Let's try the simple option of just removing this. It looks like the parent class should initialise this correctly already.

jibran’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix
renatog’s picture

It really makes sense. The parents already do this, so it's not necessary.

+1 to RTBC

  • catch committed 64aa5fa on 9.2.x
    Issue #3206358 by longwave, RenatoG: Remove bag initialization in...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 64aa5fa and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.