The search icon in Windows high contrast barely shows. This is because high contrast does not change the backgrounds or borders for SVGs.

CommentFileSizeAuthor
#8 3206290-8.patch1.79 KBmherchel
#8 ie11-search-icon-hc.png179.02 KBmherchel
#8 ff-search-icon-hc.png183.56 KBmherchel
#5 Screenshot 2021-03-30 at 10.09.52.png15.57 KBGauravvvv
#5 Screenshot 2021-03-30 at 10.07.24.png68.21 KBGauravvvv
#3 ff-high-contrast-search-icon-after.png119.56 KBmherchel
#3 ie11-high-contrast-search-icon-after.png163.4 KBmherchel
#2 3206290.patch1.15 KBmherchel
ff-high-contrast-search-icon.png97.52 KBmherchel
ie11-high-contrast-search-icon.png152.11 KBmherchel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Status: Active » Needs review
FileSize
3206290.patch1.15 KB

The solution that I implemented is to insert a white background <rect> behind the magnifying glass icon.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
FileSize
ie11-high-contrast-search-icon-after.png163.4 KB
ff-high-contrast-search-icon-after.png119.56 KB

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
Assigned: Unassigned » Gauravvvv
Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
FileSize
Screenshot 2021-03-30 at 10.07.24.png68.21 KB
Screenshot 2021-03-30 at 10.09.52.png15.57 KB

I have attached the before and after patch screenshot for reference.
Looks good. Moving to RTBC.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community
Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
Assigned: Gauravvvv » Unassigned
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Status: Reviewed & tested by the community » Needs review
FileSize
ff-search-icon-hc.png183.56 KB
ie11-search-icon-hc.png179.02 KB
3206290-8.patch1.79 KB

Discussed this with @lauriii last week. A better way to do this is to use currentColor. New patch attached.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented

Referring to screenshots provided in #8, the Icon is now visible without background color.

This is ready for RTBC.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented
Issue tags: +high contrast, +wcag131

  • lauriii committed a5fd926 on 9.2.x 
    Issue #3206290 by mherchel, Gauravmahlawat: Olivero: Windows high...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed a5fd926 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.