Problem/Motivation

This issue is to add documentation for the following source plugins:

  • d7/Field.php
  • d7/FieldableEntity.php
  • d7/FieldInstancePerFormDisplay.php
  • d7/FieldInstancePerViewMode.php
  • d7/FieldInstance.php *
  • d7/FieldLabelDescriptionTranslation.php
  • d7/FieldOptionTranslation.php

Proposed resolution

Do it.

Remaining tasks

Review, commit.

Issue fork drupal-3204986

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Matroskeen created an issue. See original summary.

Matroskeen opened merge request !452

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Evolving Web, Drupal Ukraine Community commented
Status: Active » Needs review

Ready for review 😋

d7_field_instance_per_form_display plugin looks interesting, because it just overrides getIds() method.
The same plugin for d6 version also overrides query and iterator, that's why I'm suspicious. I'll try to have another look when I have time and will create a follow-up if necessary.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Evolving Web, Drupal Ukraine Community commented
Parent issue: » #3189481: [Meta] Add source plugin documentation to the codebase
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Needs work

I was wondering when you would do 'fields'. And here it is and a nice job it is.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Evolving Web, Drupal Ukraine Community commented
Status: Needs work » Needs review

@quietone thanks! I was wondering as well... it was hard to find some spare time recently.
Pushed one more commit and commented in MR.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Needs work

@Matroskeen, Oh, we disagree on one point - I had a feeling fields would take more effort. :-)

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Evolving Web, Drupal Ukraine Community commented
Status: Needs work » Needs review

I wouldn't think disagree, we were just looking from different angles. 😉Now I think your comment makes sense, so made another attempt.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Needs work

Sorry, one more item for both Field.php and FieldInstance.php.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen at DevBranch, Evolving Web, Drupal Ukraine Community commented
Status: Needs work » Needs review

No worries :)

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

@Matroskeen, Thank you!

I reread all the comments and this is ready to go. Really nice to have the fields done.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 26c10ba29f to 9.2.x and 74f21c4552 to 9.1.x. Thanks!

As this is a docs improvement backported to 9.1.x.

  • alexpott committed 26c10ba on 9.2.x 
    Issue #3204986 by Matroskeen, quietone: Add documentation for d7 field...

  • alexpott committed 74f21c4 on 9.1.x 
    Issue #3204986 by Matroskeen, quietone: Add documentation for d7 field...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Matroskeen closed merge request !452