EntityQuery accessCheck: tests should not check access unless relevant

Problem/Motivation

As discussed in the parent issue #3200985: [meta] Fix undesirable access checking on entity query usages work on the MR for #2785449: It's too easy to write entity queries with access checks that must not have them identified many cases in core tests - touching 80+ files - where entity queries currently do not explicitly call checkAccess(). In preparation for #2785449: It's too easy to write entity queries with access checks that must not have them all of these now need to explicitly all checkAccess with TRUE or FALSE.

This is major as it blocks #2785449: It's too easy to write entity queries with access checks that must not have them.

The dilemma

This is an awful lot of changes, and the logic of tests is often hard to understand. Therefore it's unrealistic to expect anyone to study every case in detail. While we can do our best to identify cases where access checking seems part of the intended logic of the test, we will need a basic heuristic to fall back on. Should we expect TRUE or FALSE for accessCheck in tests?

The advantage of setting all test uses to TRUE is that we don't change the behavior of any test, and therefore run no risk of inadvertently undermining our coverage of possible regressions by removing access checking when it is intended.

However, using TRUE suggests that the test is intentionally considering access as part of its logic. And in mostly that is not the case, in which case FALSE is a better default for future tests. Therefore using TRUE everywhere would (a) confuse the logic and apparent intention of the existing tests, but making it seem like they care about access when they don't, and (b) create many examples of using TRUE unnecessarily that may set bad precedents for future tests.

It's hard to know how many cases thee will be of tests that use an entity query and do care about access. I suspect the answer is very few, because tests that really case about access are often functional tests that make their assertions about rendered browser content not queried entities. A test that really cares about access and is using an entity query for that purpose is likely to be quite explicit that it is testing access.

Proposed resolution

Set accessCheck(FALSE) on entity queries in core tests unless there's clear evidence from the test comments and method names that it is concerned with access.