Problem/Motivation

In #3167880: [meta] Convert assertions involving use of xpath to WebAssert, where possible we identified that use of $this->xpath() can be dangerous as we aren't always testing what we expect to test. In WebAssert we have more appropriate methods to find and assert HTML elements, so we should use them where possible.

This issue is scoped to find XPath selectors for <textarea> elements and convert those where possible.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3202915

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs work

Several conversions still to go.

longwave’s picture

Status: Needs work » Needs review

Ready for review, I think.

mondrake’s picture

Status: Needs review » Needs work

Couple nits and then this seems ready.

longwave’s picture

Status: Needs work » Needs review

Thanks for review, nits fixed.

mondrake’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

  • catch committed dc5863e on 9.2.x
    Issue #3202915 by longwave, mondrake: Convert assertions involving use...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed dc5863e and pushed to 9.2.x. Thanks!

  • catch committed 80c29ba on 9.1.x
    Issue #3202915 by longwave, mondrake: Convert assertions involving use...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.