Given allowed host *.drupal.org the following link dev.drupal.org must be allowed.

CommentFileSizeAuthor
#7 3200899-7.patch2.34 KBrp7
#6 3200899-5.patch1.12 KBneclimdul
#2 3200899-2.patch853 bytesPooja Ganjage

Comments

leymannx created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3200899-2.patch853 bytes

Hi,

Creating a patch for this issue.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
yannickoo’s picture

yannickoo
Location Berlin
commented
Assigned: Unassigned » yannickoo

Hey Pooja, thanks for your patch. Unfortunately that doesn't really help to solve this issue. We need *.drupal.org in the description text.

Assigning the issue to me

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Needs review » Active
neclimdul’s picture

neclimdul
He/Him
commented
Status: Active » Needs review
StatusFileSize
new 3200899-5.patch1.12 KB

Something like this?

rp7’s picture

rp7 commented
StatusFileSize
new 3200899-7.patch2.34 KB

#6 takes the right approach IMO. Thank you.

I improved the patch a little bit by injecting the path matcher service instead of calling it directly via \Drupal::service().

I did notice something odd though: if you configure, for example, *.drupal.org to be an allowed hostname the validation doesn't mark anything as invalid as soon as you include an asterisk in the hostname (eg. https://hello*.symfony.com/docs). Might be a bug with the patch matcher, but didn't dig deeper into it.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community

lgtm

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Version: 1.0.x-dev » 1.x-dev
Assigned: yannickoo » Unassigned
Category: Task » Bug report

  • leymannx committed 774f74a4 on 1.x authored by rp7 
    Issue #3200899 by neclimdul, rp7, leymannx: Update...
norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Reviewed & tested by the community » Fixed

Thank you!! This is out. Will be released later today.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.