If you have a contrib module for 7.x that doesn't provide the files[] array in it's .info file, and you enable that module, it causes errors in _registry_rebuild:
* notice: Undefined index: files in /Applications/MAMP/htdocs/core/includes/registry.inc on line 47.
* warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/core/includes/registry.inc on line 47.
* notice: Undefined index: files in /Applications/MAMP/htdocs/core/includes/registry.inc on line 47.
* warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/core/includes/registry.inc on line 47.
Patch adds a default $info['files'] = array() to module_rebuild_cache. Patch will also mark the module as incompatible in admin/build/modules so the rouge module cannot be enabled, since it would never be useful as no module functions would be found in the registry.
Comment | File | Size | Author |
---|---|---|---|
#8 | 320009-module-info-files-followup-D7.patch | 687 bytes | Dave Reid |
#6 | module-info-files-followup-D7.patch | 935 bytes | swentel |
#4 | module-info-files-followup-D7.patch | 687 bytes | Dave Reid |
#3 | module-info-files-followup-D7.patch | 708 bytes | Dave Reid |
module-info-files-D7.patch | 1.42 KB | Dave Reid | |
Comments
Comment #1
moshe weitzman CreditAttribution: moshe weitzman commentedNice. This removes some rather disconcerting error messages.
Comment #2
webchickYay! Thanks. :)
Comment #3
Dave ReidFollow-up patch that does the same check when everyone will be upgrading to D7 from D6!
Comment #4
Dave ReidHad a logic error.
Comment #5
webchickMacintosh-105:core webchick$ patch -p0 < module-info-files-followup-D7_0.patch
patching file update.php
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 512 with fuzz 1 (offset 1 line).
Could you give this a quick re-roll? I just stumbled across it again and it seems like a good idea. :) And now that it's actually possible to upgrade D6 => D7 we can even test it too. ;)
Comment #6
swentel CreditAttribution: swentel commentedReroll
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedThe last submitted patch failed testing.
Comment #8
Dave ReidRe-roll with matching parathesis.
Comment #10
Dave ReidFailed due to #74645: modify file_scan_directory to include a regex for the nomask.. Setting back to code needs review.
Comment #11
catchTrivial patch, RTBC.
Comment #12
webchickCommitted; thanks! :)