Problem/Motivation

  • Use AJAX to update views for the following modules:
    • aws_cloud
    • cloud
    • cloud_budget
    • k8s
    • openstack
    • terraform
    • vmaware

Issue fork cloud-3200047

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas’s picture

Status: Active » Needs review
FileSize
59.4 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3200047-3.patch, failed testing. View results

yas’s picture

Status: Needs work » Needs review
FileSize
73.03 KB

@xiaohua-guan

Could you please review the patch? Especially, I added those views from the latest code. Each K8s view has taxonomy.vocabulary.k8s_tags dependencies. Is that ok?

Thanks

Xiaohua Guan’s picture

@yas

I have just one concern about the usage of updateViewsConfiguration. Could you confirm it?

yas’s picture

FileSize
71.51 KB

@xiaohua-guan

Thank you for your review. I removed \Drupal::service('cloud')->updateViewsConfiguration() from .install files although I left the CloudService::updateViewsConfiguration() function.

yas’s picture

FileSize
70.66 KB

@xiaohua-guan

Thank you for your review. I removed $option. Could you please check it again?

Xiaohua Guan’s picture

Status: Needs review » Reviewed & tested by the community

@yas

The patch file looks good to me. So I changed the status to RTBC.

yas’s picture

@xiaohua-guan

Thank you for your review. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed eb41a77 on 3.x
    Issue #3200047 by yas, Xiaohua Guan: Use AJAX to update views
    

yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.