Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
- Use AJAX to update views for the following modules:
aws_cloud
cloud
cloud_budget
k8s
openstack
terraform
vmaware
Comment | File | Size | Author |
---|---|---|---|
#8 | 3200047-8.patch | 70.66 KB | yas |
Issue fork cloud-3200047
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3200047-use-ajax-to-update-views changes, plain diff MR !155
Comments
Comment #3
yasComment #5
yas@xiaohua-guan
Could you please review the patch? Especially, I added those views from the latest code. Each K8s view has taxonomy.vocabulary.k8s_tags dependencies. Is that ok?
Thanks
Comment #6
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas
I have just one concern about the usage of updateViewsConfiguration. Could you confirm it?
Comment #7
yas@xiaohua-guan
Thank you for your review. I removed
\Drupal::service('cloud')->updateViewsConfiguration()
from.install
files although I left theCloudService::updateViewsConfiguration()
function.Comment #8
yas@xiaohua-guan
Thank you for your review. I removed $option. Could you please check it again?
Comment #9
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas
The patch file looks good to me. So I changed the status to RTBC.
Comment #10
yas@xiaohua-guan
Thank you for your review. I'll merge the patch to
3.x
and close this issue asFixed
.Comment #13
yas