When the openid module comes back to authentication and it authenticates the user, would you be able to install a hook here hook_openid_response or something similar to that. Once the user is logged in then you can invoke the hook and pass the user account and the response.
This is so that we can have the standard openid.module and then we can also have contrib modules that will hook into that for simple registration and client attribute exchange.
I notice currently that sreg for email and nickname are already in the request, however this hook would be utilized so the contrib modules would be able too retrieve their data from the response and act upon it.
This would be called either right after each of the user_external_login function calls in that function.
Please advise if this would be something that can be considered for the openid module.
Comment | File | Size | Author |
---|---|---|---|
#6 | 319840-6_hook_response.patch | 1.88 KB | Aron Novak |
#5 | 319840-5_hook_response.patch | 1.08 KB | Aron Novak |
#3 | 319840_hook_response.patch | 1.47 KB | Aron Novak |
#3 | 319840_hook_response_HEAD.patch | 1.46 KB | Aron Novak |
#1 | openid.module.patch | 1.31 KB | darren.ferguson |
Comments
Comment #1
darren.ferguson CreditAttribution: darren.ferguson commentedSorry did not supply a patch, the attached patch is what i meant with regard to the hook required to get the response information for other modules such as Simple Registration and Attribute Exchange.
Comment #2
alex_b CreditAttribution: alex_b commentedSubscribe.
Comment #3
Aron NovakHere are two patches, one for DRUPAL-6, one for HEAD.This is basically the same as #1, but the hook_response() is called from one code place.
Comment #4
Aron NovakIt does not apply anymore to the HEAD. Needs to be rerolled.
Comment #5
Aron NovakThis patch is basically the same as #1, but rerolled to HEAD.
You can check out the concept behind this patch in the initial post of this thread, that's a nice summary!
Comment #6
Aron NovakOf course openid.api.php should be updated as well.
Comment #8
lilou CreditAttribution: lilou commentedHEAD is broken
Comment #9
moshe weitzman CreditAttribution: moshe weitzman commentedLooks good to me. There is no way that this patch breaks anything. Just adds a hook.
Comment #11
Aron NovakI'm in doubt that this is really broken or it was a glitch w/ testing infrastructure.
Comment #12
Aron Novakmoshe: thanks for the RTBC! I just restore the status of the ticket prior the crazy bot.
Comment #13
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.