Quiz results score ignores simple question option

It's strange because a question should not be able to make the score in the quiz anything higher than the scaled max. If the question in the quiz is worth 1 point then it shouldn't be possible for a 3 point question to award more than 1 point in the quiz.

There's a few tests that should be looked at, that doesn't seem right...

QuizMultichoiceTestCase::testSimpleScoring

QuizGradingTest::testWeightedScore

QuizGradingTest::testManualWeightedScore

Isn't the issue here:

multichoiceResponse.php

foreach ($alternatives as $alternative) {
      // Take action on each alternative being selected (or not).
      $vid = $alternative->getRevisionId();
      // If this alternative was selected.
      $selected = in_array($vid, $selected_vids);
      $correct = $alternative->get('multichoice_correct')->getString();

      if (!$selected && $simple && $correct) {
        // Selected this answer, simple scoring on, and the answer was incorrect.
        $score = 0;
        break;
      }

      if ($selected && $correct && !$multi) {
        // User selected a correct answer and this is not a multiple answer
        // question. User gets the point value of the question.
        $score = $alternative->get('multichoice_score_chosen')->getString();
        break;
      }

      if ($multi) {
        // In multiple answer questions we sum up all the points.
        if ($selected) {
          // Add (or subtract) some points.
          $score += $alternative->get('multichoice_score_chosen')->getString();
        }
        else {
          $score += $alternative->get('multichoice_score_not_chosen')->getString();
        }
      }
    }

    $this->setEvaluated();
    return $score;

ie: if it's a multi choice answer, the score is incremented by score_chosen / not_chosen. If we want simple scoring, wouldn't this be a better solution?

  foreach ($alternatives as $alternative) {
      $vid = $alternative->getRevisionId();
      // If this alternative was selected.
      $selected = in_array($vid, $selected_vids);
      $correct = $alternative->get('multichoice_correct')->getString();
      if ($simple){
        if (!$selected && $correct) {
          // Selected this answer, simple scoring on, and the answer was incorrect.
          $score = 0;
          break;
        }
        if ($selected && $correct) {
          $score=1;
        }
      }else{
        if ($selected && $correct && !$multi) {
          // User selected a correct answer and this is not a multiple answer
          // question. User gets the point value of the question.
          $score = $alternative->get('multichoice_score_chosen')->getString();
          break;
        }

        if ($multi) {
          // In multiple answer questions we sum up all the points.
          if ($selected) {
            // Add (or subtract) some points.
            $score += $alternative->get('multichoice_score_chosen')->getString();
          }
          else {
            $score += $alternative->get('multichoice_score_not_chosen')->getString();
          }
        }
      }
    }
    $this->setEvaluated();
    return $score;

ie: if you want simple scoring (0 or 1) any incorrect response receives a score of zero, and only gets 1 mark if there are no incorrect answers.

I slightly updated Martins solution, to prevent that a user gets points if he/she selects all alternatives of a multiplechoice question (both correct and wrong ones) and created a patch.
if ((!$selected && $correct) || ($selected && !$correct))

There's a couple issue here contributing to the issue:

1. The forgive() method which corrects the multichoice_score_[not_]chosen if omitted, was broken from D7
2. score() was returning more points than the max points when using simple scoring
3. The warn() method was still broken from D7

This should fix that all up against 6.x. Test has to be updated.

Fix MCQ test

Updated testSimpleScoring to set 2 correct answers and then check for the proper score, it wasn't doing that before.

Test patch fails, full patch passes.

Thanks all, fixed!