Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.During a D7-to-D8 webform migration (which is almost out-of-the-box, thanks to webform_migrate module!), I ran into several error when accessing my webform settings form for the first time. Some default where not set by the migration.
Error example : Notice: Undefined index: page_submit_path in Drupal\webform\Entity\Webform->updatePaths() (line 2385 of modules/contrib/webform/src/Entity/Webform.php).
While I'll fix my own migration tohave better defaults, I guess the Webform Entity Class may prevent accessing undefined index by using the (already existing) helper getSetting() instead of accessing the settings array. I'll attach a patch in the next comment.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3194629-4.patch | 1.58 KB | jrockowitz |
| |||
| #2 | 3194629_use_getsetting_helper_1.patch | 1.52 KB | opi |
Comments
Comment #2
opiComment #3
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedWe should backport this patch to 8.x-5.x.
Comment #4
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #5
opi> We should backport this patch to 8.x-5.x.
Oh sorry about that, and thanks for the patch!
Comment #8
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented