WebformElement WebformComputedBase::getMode() calls WebformComputedBaseElement::getMode(), causing the WebformComputedBaseElement::getMode() function to not be overridable when extending the WebformComputedBaseElement class.

Patch incoming.

CommentFileSizeAuthor
#2 getmode_should_be_extendable-3194187-2.patch631 bytesmatthiasm11
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

matthiasm11 created an issue. See original summary.

matthiasm11’s picture

matthiasm11 CreditAttribution: matthiasm11 at MM-Experience commented
Issue summary: View changes
Status: Active » Needs review
FileSize
getmode_should_be_extendable-3194187-2.patch631 bytes

Fixed in the attached patch.
Used the same approach as WebformElement WebformComputedBase::computeValue().

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs review » Reviewed & tested by the community
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Reviewed & tested by the community » Fixed

  • matthiasm11 authored 0d50997 on 8.x-5.x 
    Issue #3194187 by matthiasm11: getMode should be extendable
  • matthiasm11 authored 0d50997 on 8.x-5.x
    Issue #3194187 by matthiasm11: getMode should be extendable

  • matthiasm11 authored 0d50997 on 6.x 
    Issue #3194187 by matthiasm11: getMode should be extendable
  • matthiasm11 authored 0d50997 on 6.x
    Issue #3194187 by matthiasm11: getMode should be extendable

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.