Problem/Motivation

Instancing of a new "OpenID Connect login" will fail, due to an improper typehint in OpenIDConnectLoginBlock::__construct().

Steps to reproduce

  1. Go to /admin/structure/block
  2. Try to place an "OpenID Connect login" block; it fails silently, no config form is displayed.

Proposed resolution

Update typehint in OpenIDConnectLoginBlock::__construct(), so that it matches Drupal\Core\Plugin\ContainerFactoryPluginInterface::create().

Remaining tasks

  • Third party review and testing.

Issue fork openid_connect-3193374

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jedihe created an issue. See original summary.

jedihe’s picture

jedihe CreditAttribution: jedihe at Council on Foreign Relations commented
Issue summary: View changes

jedihe opened merge request !6

jedihe’s picture

jedihe CreditAttribution: jedihe at Council on Foreign Relations commented
Issue summary: View changes
jedihe’s picture

jedihe CreditAttribution: jedihe at Council on Foreign Relations commented
Issue summary: View changes
jedihe’s picture

jedihe CreditAttribution: jedihe at Council on Foreign Relations commented
Assigned: jedihe » Unassigned
Issue summary: View changes
Status: Active » Needs review

Given the code change is fully justifiable just to satisfy the signature of the interface, I don't think automated testing is really needed here.

  • jedihe authored c6191a4 on 2.x 
    Issue #3193374 by jedihe, jcnventura: Incorrect typehint prevents...
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.